From: Laurent Vivier <lvivier@redhat.com>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>,
Juan Quintela <quintela@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/2] spapr: skip configuration section during migration of older machines
Date: Thu, 18 Feb 2016 20:57:19 +0100 [thread overview]
Message-ID: <56C6221F.5070505@redhat.com> (raw)
In-Reply-To: <20160218113218.9760.89211.stgit@bahia.huguette.org>
On 18/02/2016 12:32, Greg Kurz wrote:
> Since QEMU 2.4, we have a configuration section in the migration stream.
> This must be skipped for older machines, like it is already done for x86.
>
> This patch fixes the migration of pseries-2.3 from/to QEMU 2.3, but it
> breaks migration of the same machine from/to QEMU 2.4/2.4.1/2.5. We do
> that anyway because QEMU 2.3 is likely to be more widely deployed than
> newer QEMU versions.
>
> Fixes: 61964c23e5ddd5a33f15699e45ce126f879e3e33
> Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
> ---
> hw/ppc/spapr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 5bd8fd3ef842..bca7cb8a5d27 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -2446,6 +2446,7 @@ static void spapr_machine_2_3_instance_options(MachineState *machine)
> spapr_machine_2_4_instance_options(machine);
> savevm_skip_section_footers();
> global_state_set_optional();
> + savevm_skip_configuration();
> }
>
> static void spapr_machine_2_3_class_options(MachineClass *mc)
>
next prev parent reply other threads:[~2016-02-18 19:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 11:32 [Qemu-devel] [PATCH v3 0/2] Fix migration of old pseries Greg Kurz
2016-02-18 11:32 ` [Qemu-devel] [PATCH v3 1/2] spapr: skip configuration section during migration of older machines Greg Kurz
2016-02-18 19:57 ` Laurent Vivier [this message]
2016-02-23 8:23 ` Juan Quintela
2016-02-18 11:32 ` [Qemu-devel] [PATCH v3 2/2] migration: allow machine to enforce configuration section migration Greg Kurz
2016-02-18 19:57 ` Laurent Vivier
2016-02-23 8:24 ` Juan Quintela
2016-02-18 20:00 ` [Qemu-devel] [PATCH v3 0/2] Fix migration of old pseries Laurent Vivier
2016-02-19 6:42 ` Greg Kurz
2016-02-19 0:11 ` David Gibson
2016-02-19 7:59 ` Greg Kurz
2016-02-22 1:09 ` David Gibson
2016-02-26 10:49 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2016-02-26 11:03 ` David Gibson
2016-02-23 8:31 ` [Qemu-devel] " Juan Quintela
2016-02-23 10:01 ` Greg Kurz
2016-02-23 12:27 ` Greg Kurz
2016-02-19 14:41 ` Laurent Vivier
2016-02-19 16:27 ` Greg Kurz
2016-02-23 15:04 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C6221F.5070505@redhat.com \
--to=lvivier@redhat.com \
--cc=amit.shah@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).