From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52523)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lvivier@redhat.com>) id 1aWUkp-0003ih-Gw
	for qemu-devel@nongnu.org; Thu, 18 Feb 2016 15:00:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lvivier@redhat.com>) id 1aWUkm-0005Ut-2f
	for qemu-devel@nongnu.org; Thu, 18 Feb 2016 15:00:47 -0500
References: <20160218113211.9760.85475.stgit@bahia.huguette.org>
From: Laurent Vivier <lvivier@redhat.com>
Message-ID: <56C622E6.20909@redhat.com>
Date: Thu, 18 Feb 2016 21:00:38 +0100
MIME-Version: 1.0
In-Reply-To: <20160218113211.9760.85475.stgit@bahia.huguette.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 0/2] Fix migration of old pseries
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>, Juan Quintela <quintela@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>, David Gibson <david@gibson.dropbear.id.au>, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, "Dr. David Alan Gilbert" <dgilbert@redhat.com>



On 18/02/2016 12:32, Greg Kurz wrote:
> QEMU 2.4 broke the migration of old pseries machine with the addition
> of configuration sections, which are sent unconditionally.
> 
> We assume that QEMU 2.3 is more deployed than any newer release (based on
> the versions currently shipped by most distros). This v3 series hence
> reverses the logic from v2: it now fully fixes migration of old pseries
> from/to QEMU 2.3 and provides a manual workaround for the QEMU 2.4/2.4.1/2.5
> case.
> 
> With this series, I could migrate the same pseries-2.3 instance in a full
> 2.3->2.6->2.5->2.6->2.4->2.6->2.3 cycle.
> 
> ---
> 
> Greg Kurz (2):
>       spapr: skip configuration section during migration of older machines
>       migration: allow machine to enforce configuration section migration
> 
> 
>  hw/core/machine.c   |   21 +++++++++++++++++++++
>  hw/ppc/spapr.c      |    1 +
>  include/hw/boards.h |    1 +
>  migration/savevm.c  |   10 ++++++++--
>  qemu-options.hx     |    3 ++-
>  5 files changed, 33 insertions(+), 3 deletions(-)

For the series
Tested-by: Laurent Vivier <lvivier@redhat.com>

Results of tests:

pseries-2.3

    qemu-2.3.0 -> qemu-master: OK
    qemu-2.3.1 -> qemu-master: OK
    qemu-2.4.0 -> qemu-master: OK with qom-set
    qemu-2.4.1 -> qemu-master: OK with qom-set
    qemu-2.5.0 -> qemu-master: OK with qom-set
    qemu-master -> qemu-2.3.0: OK
    qemu-master -> qemu-2.3.1: OK
    qemu-master -> qemu-2.4.0: OK with qom-set
    qemu-master -> qemu-2.4.1: OK with qom-set
    qemu-master -> qemu-2.5.0: OK with qom-set
    qemu-master -> qemu-master: OK

pseries-2.4, pseries-2.5 and pseries-2.6 works well with the patch
applied too.

master is "b527c9b qcow2: Write full header on image creation" + this series

Laurent