From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWUku-0003jg-ED for qemu-devel@nongnu.org; Thu, 18 Feb 2016 15:00:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWUks-0005VP-Vx for qemu-devel@nongnu.org; Thu, 18 Feb 2016 15:00:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49458) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWUks-0005VL-Iy for qemu-devel@nongnu.org; Thu, 18 Feb 2016 15:00:50 -0500 References: <1455778109-6278-1-git-send-email-eblake@redhat.com> <1455778109-6278-13-git-send-email-eblake@redhat.com> <874md69dfi.fsf@blackfin.pond.sub.org> <56C5F7D6.4060801@redhat.com> <87fuwp26f9.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <56C622F1.1020602@redhat.com> Date: Thu, 18 Feb 2016 13:00:49 -0700 MIME-Version: 1.0 In-Reply-To: <87fuwp26f9.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="URHXSU0PO5XTccSFETguxh0P98FPLdfR4" Subject: Re: [Qemu-devel] [PATCH v11 12/15] qapi: Don't box struct branch of alternate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --URHXSU0PO5XTccSFETguxh0P98FPLdfR4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/18/2016 11:56 AM, Markus Armbruster wrote: > Better, but the sentence is long enough to confuse even a German. What= > about: lol >=20 > The corresponding spot in qapi-visit.c calls visit_type_FOO(), whic= h > first calls visit_start_struct() to allocate or deallocate the memb= er > and handle a layer of {} from the JSON stream, then visits the > members. To peel off the indirection and the memory management tha= t > comes with it, we inline this call, then suppress allocation / > deallocation by passing NULL to visit_start_struct(), and adjust th= e > member visit: Works for me. [Technically, visit_start_struct() never deallocates, it merely records a pointer for later deallocation during visit_end_struct(); but I don't think we need to worry about the imprecision here] --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --URHXSU0PO5XTccSFETguxh0P98FPLdfR4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWxiLxAAoJEKeha0olJ0Nq5+MH/1Ite8hYdqHqntppU3C0QN8e zw01whK2ItHbS0mXO7hdATZRsWoN5UnyyEwnjYyGCO/XjB3xg/gzHCfa4mb+Nv8t KM12/+ybXXtD447P8iU531LwSnBgRXXP6OIVOHkvIWWcmoHL3gyuYop8YtbDmJzb MkjWZlotNHpcfNT9cLW9G0QuGNp2cKyItEBPsnRRk76kLnIpY7HZ3CrTQZY9sWQ0 mGmN5Ur02IwFCYH3pWBh9m/OyPY8BM+INTzvPBgmk1K1o3ZfZBrRNzObviN148oM cB+3w18mk3Lr+BEyuWdmaZZWJzbL3IZgX0svJ4jWEKskNEaOy8Q7KrPvPRJJiQ8= =lanD -----END PGP SIGNATURE----- --URHXSU0PO5XTccSFETguxh0P98FPLdfR4--