From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 0/8] more include cleaning
Date: Thu, 18 Feb 2016 13:04:30 -0700 [thread overview]
Message-ID: <56C623CE.80105@redhat.com> (raw)
In-Reply-To: <1455818725-7647-1-git-send-email-peter.maydell@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1613 bytes --]
On 02/18/2016 11:05 AM, Peter Maydell wrote:
> This patchset makes more progress with with cleaning our
> include use and is hopefully the last of the big ones
> (there are some other minor fixups that can be done after).
>
> Patch 1 is already in Andreas' QOM tree but I include it
> for convenience since without it things will fail to compile
> later in the series.
> Patch 2 fixes a problem with including osdep.h first in
> arm-a64.cc if the compiler doesn't support C++11
> Patch 3 is the previously sent arm-a64.cc change
> Patches 4 and 5 add support to the clean-includes script
> for working on .h files, and for saying "run on everything
> in the source tree"
> Patch 6 fixes something I had forgotten about -- osdep.h
> needs to include config-target.h if the object file being
> built is a per-target one!
> Patch 7 is the results of cleaning everything except include/.
> Patch 8 cleans include/.
>
> In particular, since patch 8 removes the osdep.h include from
> qemu-common.h it is where you will see compile failures if anything
> isn't including osdep.h (this builds fine against current master but
> might break in-flight patches and other out of tree code if it does
> not include osdep.h everywhere it should).
>
> I could split patches 7 and 8 up into smaller chunks if that seems
> helpful to people, but I figured they weren't too terrible as-is.
>
> thanks
> -- PMM
>
>
> Peter Maydell (8):
Tested-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2016-02-18 20:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 18:05 [Qemu-devel] [PATCH 0/8] more include cleaning Peter Maydell
2016-02-18 18:05 ` [Qemu-devel] [PATCH 1/8] cpu: Clean up includes Peter Maydell
2016-02-18 18:05 ` [Qemu-devel] [PATCH 2/8] osdep.h: Define macros for the benefit of C++ before C++11 Peter Maydell
2016-02-18 18:51 ` Eric Blake
2016-02-18 18:05 ` [Qemu-devel] [PATCH 3/8] disas/arm-a64.cc: Include osdep.h first Peter Maydell
2016-02-18 18:05 ` [Qemu-devel] [PATCH 4/8] scripts/clean-includes: Enhance to handle header files Peter Maydell
2016-02-18 18:36 ` Peter Maydell
2016-02-18 19:04 ` Eric Blake
2016-02-18 20:07 ` Peter Maydell
2016-02-19 18:03 ` Peter Maydell
2016-02-18 18:05 ` [Qemu-devel] [PATCH 5/8] scripts/clean-includes: Add --all option Peter Maydell
2016-02-18 19:09 ` Eric Blake
2016-02-18 18:05 ` [Qemu-devel] [PATCH 6/8] osdep.h: Include config-target.h if NEED_CPU_H is defined Peter Maydell
2016-02-18 19:09 ` Eric Blake
2016-02-18 18:05 ` [Qemu-devel] [PATCH 7/8] all: Clean up includes Peter Maydell
2016-02-18 19:16 ` Eric Blake
2016-02-18 20:10 ` Peter Maydell
2016-02-18 18:05 ` [Qemu-devel] [PATCH 8/8] include: " Peter Maydell
2016-02-18 19:54 ` Eric Blake
2016-02-18 20:12 ` Peter Maydell
2016-02-18 20:04 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C623CE.80105@redhat.com \
--to=eblake@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).