From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46674)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <frankja@linux.vnet.ibm.com>) id 1aWfQ5-0000Fo-2V
	for qemu-devel@nongnu.org; Fri, 19 Feb 2016 02:24:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <frankja@linux.vnet.ibm.com>) id 1aWfQ1-0002r1-2K
	for qemu-devel@nongnu.org; Fri, 19 Feb 2016 02:24:05 -0500
Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:60276)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <frankja@linux.vnet.ibm.com>) id 1aWfQ0-0002qx-Ol
	for qemu-devel@nongnu.org; Fri, 19 Feb 2016 02:24:01 -0500
Received: from localhost
	by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <frankja@linux.vnet.ibm.com>;
	Fri, 19 Feb 2016 07:23:59 -0000
Received: from b06cxnps3075.portsmouth.uk.ibm.com
	(d06relay10.portsmouth.uk.ibm.com [9.149.109.195])
	by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 1205C2190023
	for <qemu-devel@nongnu.org>; Fri, 19 Feb 2016 07:23:43 +0000 (GMT)
Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com
	[9.149.37.251])
	by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id u1J7Nvvn37945402
	for <qemu-devel@nongnu.org>; Fri, 19 Feb 2016 07:23:58 GMT
Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id u1J6Nxmo007492
	for <qemu-devel@nongnu.org>; Thu, 18 Feb 2016 23:23:59 -0700
References: <1455848416-13177-1-git-send-email-famz@redhat.com>
From: Janosch Frank <frankja@linux.vnet.ibm.com>
Message-ID: <56C6C30D.2030604@linux.vnet.ibm.com>
Date: Fri, 19 Feb 2016 08:23:57 +0100
MIME-Version: 1.0
In-Reply-To: <1455848416-13177-1-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] scripts/kvm/kvm_stat: Fix missing right
 parantheses and ".format(...)"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, "Jason J. Herne" <jjherne@linux.vnet.ibm.com>, frankja@linux.vnet.ibm.com

On 02/19/2016 03:20 AM, Fam Zheng wrote:
> They seem to have snuck in when applying Janosch Frank
> <frankja@linux.vnet.ibm.com>'s previous patch.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> 
> ---
> v2: Also fix .format. [Janosch]
> ---
>  scripts/kvm/kvm_stat | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
> index 3cf1181..769d884 100755
> --- a/scripts/kvm/kvm_stat
> +++ b/scripts/kvm/kvm_stat
> @@ -796,11 +796,12 @@ def check_access(options):
>          sys.stderr.write("Please enable CONFIG_TRACING in your kernel "
>                           "when using the option -t (default).\n"
>                           "If it is enabled, make {0} readable by the "
> -                         "current user.\n")
> +                         "current user.\n"
> +                         .format(PATH_DEBUGFS_TRACING))
>          if options.tracepoints:
>              sys.exit(1)
> 
> -        sys.stderr.write("Falling back to debugfs statistics!\n"
> +        sys.stderr.write("Falling back to debugfs statistics!\n")
>          options.debugfs = True
>          sleep(5)
> 
Reviewed-by: Janosch Frank <frankja@linux.vnet.ibm.com>
Tested-by: Janosch Frank <frankja@linux.vnet.ibm.com>

Thanks