qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH 1/1] virtio-rng: fix condition checking on period_ms
@ 2016-02-19 18:13 Wei Huang
  2016-02-19 20:57 ` Laszlo Ersek
  0 siblings, 1 reply; 4+ messages in thread
From: Wei Huang @ 2016-02-19 18:13 UTC (permalink / raw)
  To: qemu-devel; +Cc: qemu-trivial, mst

The condition checking on vrng->conf.period_ms appears to be wrong,
conflicting with the error comment following it.

Signed-off-by: Wei Huang <wei@redhat.com>
---
 hw/virtio/virtio-rng.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c
index 473c044..a06427c 100644
--- a/hw/virtio/virtio-rng.c
+++ b/hw/virtio/virtio-rng.c
@@ -149,7 +149,7 @@ static void virtio_rng_device_realize(DeviceState *dev, Error **errp)
     VirtIORNG *vrng = VIRTIO_RNG(dev);
     Error *local_err = NULL;
 
-    if (!vrng->conf.period_ms > 0) {
+    if (!(vrng->conf.period_ms > 0)) {
         error_setg(errp, "'period' parameter expects a positive integer");
         return;
     }
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-02-19 21:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-19 18:13 [Qemu-devel] [PATCH 1/1] virtio-rng: fix condition checking on period_ms Wei Huang
2016-02-19 20:57 ` Laszlo Ersek
2016-02-19 20:59   ` Laszlo Ersek
2016-02-19 21:07     ` Wei Huang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).