From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXWMq-0002Dy-5C for qemu-devel@nongnu.org; Sun, 21 Feb 2016 10:56:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXWMl-0008T1-4R for qemu-devel@nongnu.org; Sun, 21 Feb 2016 10:56:16 -0500 Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]:35850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXWMk-0008Sj-T3 for qemu-devel@nongnu.org; Sun, 21 Feb 2016 10:56:11 -0500 Received: by mail-wm0-x22b.google.com with SMTP id g62so139847936wme.1 for ; Sun, 21 Feb 2016 07:56:10 -0800 (PST) References: <1455852618-5224-1-git-send-email-peterx@redhat.com> <1455852618-5224-12-git-send-email-peterx@redhat.com> From: Marcel Apfelbaum Message-ID: <56C9DE17.6020604@gmail.com> Date: Sun, 21 Feb 2016 17:56:07 +0200 MIME-Version: 1.0 In-Reply-To: <1455852618-5224-12-git-send-email-peterx@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 11/13] intel_iommu: add IR translation faults defines Reply-To: marcel@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu , qemu-devel@nongnu.org Cc: ehabkost@redhat.com, mst@redhat.com, jasowang@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, rth@twiddle.net On 02/19/2016 05:30 AM, Peter Xu wrote: > Adding translation fault definitions for interrupt remapping. Please > refer to VT-d spec section 7.1. > > Signed-off-by: Peter Xu > --- > hw/i386/intel_iommu_internal.h | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h > index 309833f..c66cb83 100644 > --- a/hw/i386/intel_iommu_internal.h > +++ b/hw/i386/intel_iommu_internal.h > @@ -271,6 +271,21 @@ typedef enum VTDFaultReason { > * context-entry. > */ > VTD_FR_CONTEXT_ENTRY_TT, > + > + /* > + * Interrupt remapping transition faults > + */ > + VTD_FR_IR_REQ_RSVD = 0x20, /* One or more IR request resved > + * fields set */ Hi, Minor comments: resved -> reserved I would keep comments single line when possible even on top of the code line. Thanks, Marcel > + VTD_FR_IR_INDEX_OVER = 0x21, /* Index value greater than max */ > + VTD_FR_IR_ENTRY_P = 0x22, /* Present (P) not set in IRTE */ > + VTD_FR_IR_ROOT_INVAL = 0x23, /* IR Root table invalid */ > + VTD_FR_IR_IRTE_RSVD = 0x24, /* IRTE Rsvd field non-zero with > + * Present flag set */ > + VTD_FR_IR_REQ_COMPAT = 0x25, /* Encountered compatible IR > + * request while disabled */ > + VTD_FR_IR_SID_ERR = 0x26, /* Invalid Source-ID */ > + > /* This is not a normal fault reason. We use this to indicate some faults > * that are not referenced by the VT-d specification. > * Fault event with such reason should not be recorded. >