From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54904)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1aXaK0-0004vh-3H
	for qemu-devel@nongnu.org; Sun, 21 Feb 2016 15:09:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1aXaJw-0004ed-SM
	for qemu-devel@nongnu.org; Sun, 21 Feb 2016 15:09:36 -0500
Received: from mout.web.de ([212.227.17.12]:59108)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1aXaJw-0004eZ-If
	for qemu-devel@nongnu.org; Sun, 21 Feb 2016 15:09:32 -0500
References: <1456078260-6669-1-git-send-email-davidkiarie4@gmail.com>
	<1456078260-6669-3-git-send-email-davidkiarie4@gmail.com>
From: Jan Kiszka <jan.kiszka@web.de>
Message-ID: <56CA1975.1020609@web.de>
Date: Sun, 21 Feb 2016 21:09:25 +0100
MIME-Version: 1.0
In-Reply-To: <1456078260-6669-3-git-send-email-davidkiarie4@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="eqigpCfsPwuRk5ASwkMCD3CNNKO9Au0Mg"
Subject: Re: [Qemu-devel] [V6 2/4] hw/core: Add AMD IOMMU to machine
	properties
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Kiarie <davidkiarie4@gmail.com>, qemu-devel@nongnu.org
Cc: marcel@redhat.com, valentine.sinitsyn@gmail.com, mst@redhat.com

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--eqigpCfsPwuRk5ASwkMCD3CNNKO9Au0Mg
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: quoted-printable

On 2016-02-21 19:10, David Kiarie wrote:
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 2f0465e..dad160f 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -38,7 +38,7 @@ DEF("machine", HAS_ARG, QEMU_OPTION_machine, \
>      "                kvm_shadow_mem=3Dsize of KVM shadow MMU\n"
>      "                dump-guest-core=3Don|off include guest memory in =
a core dump (default=3Don)\n"
>      "                mem-merge=3Don|off controls memory merge support =
(default: on)\n"
> -    "                iommu=3Don|off controls emulated Intel IOMMU (VT-=
d) support (default=3Doff)\n"
> +    "                iommu=3Damd|intel enables and selects the emulate=
d IOMMU (default: off)\n"

We should also support "iommu=3Doff" or "none" to explicitly disable it.
That is consistent with other switches, and maybe there will once be a
machine type (chipset) with IOMMU enabled by default.

Jan


--eqigpCfsPwuRk5ASwkMCD3CNNKO9Au0Mg
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlbKGXUACgkQitSsb3rl5xTTiQCgiEkdWqLZnYMTCF9lXjczjdFQ
0QQAoMaIeqJ4v2XlUcsez5/OSqecWjg5
=Rd+8
-----END PGP SIGNATURE-----

--eqigpCfsPwuRk5ASwkMCD3CNNKO9Au0Mg--