From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51608)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zxq_yx_007@163.com>) id 1aXmhr-00058U-He
	for qemu-devel@nongnu.org; Mon, 22 Feb 2016 04:23:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zxq_yx_007@163.com>) id 1aXmhq-0007Xx-Jq
	for qemu-devel@nongnu.org; Mon, 22 Feb 2016 04:23:03 -0500
References: <1456110933-5457-1-git-send-email-zxq_yx_007@163.com>
	<1456110933-5457-10-git-send-email-zxq_yx_007@163.com>
	<CAFEAcA-iTcWTX5eVpe9NWb5MqYVcxUajRCnzQVFY=raBq-an4w@mail.gmail.com>
From: hitmoon <zxq_yx_007@163.com>
Message-ID: <56CAD2D7.2000009@163.com>
Date: Mon, 22 Feb 2016 17:20:23 +0800
MIME-Version: 1.0
In-Reply-To: <CAFEAcA-iTcWTX5eVpe9NWb5MqYVcxUajRCnzQVFY=raBq-an4w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v4 9/9] hw/timer: QOM'ify tusb6010
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>, Igor Mitsyanko <i.mitsyanko@gmail.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, QEMU Developers <qemu-devel@nongnu.org>, Michael Walle <michael@walle.cc>, qemu-arm <qemu-arm@nongnu.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Maksim Kozlov <m.kozlov@samsung.com>, =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>


在 2016年02月22日 17:18, Peter Maydell 写道:
> On 22 February 2016 at 03:15, xiaoqiang zhao <zxq_yx_007@163.com> wrote:
>> Move majority of old SysBus init's work the into instance_init.
>>
>> Note:
>> musb_init must be called in SysBus's init, otherwise it will
>> break "make check" with error message as follows:
>>
>> qom/object.c:1576:object_get_canonical_path_component: assertion failed: (obj->parent != NULL)
>>
>> Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
>> ---
>>   hw/timer/tusb6010.c | 23 ++++++++++++++++-------
>>   1 file changed, 16 insertions(+), 7 deletions(-)
> Devices should either be instance_init + realize, or
> sysbus-init. This patch would make this device be a mix
> of both. You should just drop this patch until musb has
> been properly QOMified.
>
> thanks
> -- PMM
Ok.