From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXtYK-0003dS-0j for qemu-devel@nongnu.org; Mon, 22 Feb 2016 11:41:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXtYF-0007IC-UD for qemu-devel@nongnu.org; Mon, 22 Feb 2016 11:41:39 -0500 References: <9d9251ff6fa1eb481ee57965bf2e6161649534e8.1455788710.git.berto@igalia.com> From: Eric Blake Message-ID: <56CB3A37.7070408@redhat.com> Date: Mon, 22 Feb 2016 09:41:27 -0700 MIME-Version: 1.0 In-Reply-To: <9d9251ff6fa1eb481ee57965bf2e6161649534e8.1455788710.git.berto@igalia.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kG7mJTbLCpWuAHtVhoogqbWH1VccOJ7Cf" Subject: Re: [Qemu-devel] [PATCH v2 10/17] qapi: Add burst length parameters to block_set_io_throttle List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: Kevin Wolf , Max Reitz , Stefan Hajnoczi , qemu-block@nongnu.org, Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kG7mJTbLCpWuAHtVhoogqbWH1VccOJ7Cf Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/18/2016 03:27 AM, Alberto Garcia wrote: > This patch adds the new bps_*_max_length and iops_*_max_length > parameters to the block_set_io_throttle command. >=20 > Signed-off-by: Alberto Garcia > --- > blockdev.c | 31 +++++++++++++++++++++++++++++++ > hmp.c | 12 ++++++++++++ > qapi/block-core.json | 51 ++++++++++++++++++++++++++++++++++++++++++++= +------ > qmp-commands.hx | 25 ++++++++++++++++--------- > 4 files changed, 104 insertions(+), 15 deletions(-) >=20 > diff --git a/blockdev.c b/blockdev.c > index e8871fc..a5523ec 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -2590,6 +2590,18 @@ void qmp_block_set_io_throttle(const char *devic= e, int64_t bps, int64_t bps_rd, > int64_t iops_rd_max, > bool has_iops_wr_max, > int64_t iops_wr_max, > + bool has_bps_max_length, > + int64_t bps_max_length, > + bool has_bps_rd_max_length, > + int64_t bps_rd_max_length, > + bool has_bps_wr_max_length, > + int64_t bps_wr_max_length, > + bool has_iops_max_length, > + int64_t iops_max_length, > + bool has_iops_rd_max_length, > + int64_t iops_rd_max_length, > + bool has_iops_wr_max_length, > + int64_t iops_wr_max_length, > bool has_iops_size, > int64_t iops_size, > bool has_group, Not a problem with this patch, but your argument list is getting painfully long; so we really want to simplify this once my boxed parameters for commands lands: https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg04394.html --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kG7mJTbLCpWuAHtVhoogqbWH1VccOJ7Cf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWyzo3AAoJEKeha0olJ0NqP9wH+wV+Ej0ECurShPK8k3/vNaUe 2rtFBn8fJIG4p+dcImKoTl+R98l61y6i6EOrjvhnWnmOVSbjOih1JXXW9jphy4zn jhObtCRYjbnErkho4aaQ5rfEQ/NpLlTQ52inONog2heZ+LGKy1mzsByojXFFyetz 3UubyjDDtSOG4f2ZBeh0RdlPv4wJ5HdLlUJktIhcingCFq92Q0tLo4V50VQXxVP7 DmiIYZ2n8y4v31DMlpT8eRUUHPG2+4jDubGa32tTjMSAKH+y3/UfkkRGBmufMMQs nXYLGYi8D2XvQcJKwVuYOsMwEfAuV+V3RaFBT64ilJXJfjrFICieC9KOekoY/8Y= =SSo8 -----END PGP SIGNATURE----- --kG7mJTbLCpWuAHtVhoogqbWH1VccOJ7Cf--