From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXtg8-0000Wo-An for qemu-devel@nongnu.org; Mon, 22 Feb 2016 11:49:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXtg7-0001gj-9O for qemu-devel@nongnu.org; Mon, 22 Feb 2016 11:49:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXtg7-0001gX-1K for qemu-devel@nongnu.org; Mon, 22 Feb 2016 11:49:43 -0500 References: <1456117285-22273-1-git-send-email-bharata@linux.vnet.ibm.com> <1456117285-22273-8-git-send-email-bharata@linux.vnet.ibm.com> From: Eric Blake Message-ID: <56CB3C24.5060001@redhat.com> Date: Mon, 22 Feb 2016 09:49:40 -0700 MIME-Version: 1.0 In-Reply-To: <1456117285-22273-8-git-send-email-bharata@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cSJBKeb1LqgLxpvpF95l1gdioGWA1Ttcq" Subject: Re: [Qemu-devel] [RFC PATCH v0 7/8] qmp: Implement query cpu-packages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao , qemu-devel@nongnu.org Cc: ehabkost@redhat.com, aik@ozlabs.ru, armbru@redhat.com, agraf@suse.de, pbonzini@redhat.com, imammedo@redhat.com, afaerber@suse.de, david@gibson.dropbear.id.au This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cSJBKeb1LqgLxpvpF95l1gdioGWA1Ttcq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/21/2016 10:01 PM, Bharata B Rao wrote: > Signed-off-by: Bharata B Rao > --- > hw/cpu/package.c | 19 +++++++++++++ > hw/ppc/spapr.c | 79 +++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > include/hw/boards.h | 1 + > qapi-schema.json | 48 ++++++++++++++++++++++++++++++++ > 4 files changed, 147 insertions(+) >=20 > +++ b/qapi-schema.json > @@ -4083,3 +4083,51 @@ > ## > { 'enum': 'ReplayMode', > 'data': [ 'none', 'record', 'play' ] } > + > +## > +# @CPUThreadInfo: > +# > +# Information about CPU Threads > +# Missing documentation for the fields. > +# Since: 2.6 > +## > + > +{ 'struct': 'CPUInfo', > + 'data': { 'arch_id': 'int', New QMP code should favor '-' over '_'; this should be 'arch-id'. > + 'type': 'str', Is this string free-form, or is it a finite set of values? If the latter, then it should be an enum type. > + '*thread': 'int', > + '*core': 'int', > + '*socket' : 'int', > + '*node' : 'int', > + '*qom_path': 'str' 'qom-path'. But this one is definitely free-form, so 'str' is right. > + } > +} > + > +## > +# @CPUPackageInfo: > +# > +# Information about CPU Packages > +# Missing field documentation. > +# Since: 2.6 > +## > + > +{ 'struct': 'CPUPackageInfo', > + 'data': { '*id': 'str', > + 'type': 'str', > + 'qom_path': 'str', > + 'realized': 'bool', > + 'nr_cpus': 'int', 'nr-cpus'. Is this field redundant, given that the caller can just count the length of the 'cpus' array? > + 'cpus' : ['CPUInfo'] > + } > +} > + > +## > +# @query-cpu-packages: > +# > +# Returns information for all CPU packages > +# > +# Returns: a list of @CPUPackageInfo > +# > +# Since: 2.6 > +## > +{ 'command': 'query-cpu-packages', 'returns': ['CPUPackageInfo'] } >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --cSJBKeb1LqgLxpvpF95l1gdioGWA1Ttcq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWyzwlAAoJEKeha0olJ0NqSEUH/i9u1VqtzSiy1DRdluSxfaRw eFI6H1HTDRcV1Em0c26iAu4aH7ikD5s1p38X9fI3oxeBUzA1wlmb5Mda0qmgYlsv TDfeBifwayUiiRxM0r93ZrmgsTQ2qvv6EzM24d3CzYKKk0pWXkpFmQMZLbknpeQH VKDLPS6Cm+LdmSzU07xnfIHUozrYmsA38xT472RHiUTA/SKR/qUTTw03RxJvvDZA gvbuDD0zqKoyaeDYsmgQLiMpCACjNA/noK7wYUraCCxykTrs3S7/gZ3MhVWBi+k0 gHAvIDm1FBTWAkXjZ+LihRynJ0foEo1I3N9oxGsPtnLrYc6MyK3xuzFba7/EwTk= =nuCc -----END PGP SIGNATURE----- --cSJBKeb1LqgLxpvpF95l1gdioGWA1Ttcq--