From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Janosch Frank <frankja@linux.vnet.ibm.com>,
"Jason J. Herne" <jjherne@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v2] scripts/kvm/kvm_stat: Fix missing right parantheses and ".format(...)"
Date: Mon, 22 Feb 2016 18:40:43 +0100 [thread overview]
Message-ID: <56CB481B.602@redhat.com> (raw)
In-Reply-To: <1455848416-13177-1-git-send-email-famz@redhat.com>
On 19/02/2016 03:20, Fam Zheng wrote:
> They seem to have snuck in when applying Janosch Frank
> <frankja@linux.vnet.ibm.com>'s previous patch.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
>
> ---
> v2: Also fix .format. [Janosch]
> ---
> scripts/kvm/kvm_stat | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
> index 3cf1181..769d884 100755
> --- a/scripts/kvm/kvm_stat
> +++ b/scripts/kvm/kvm_stat
> @@ -796,11 +796,12 @@ def check_access(options):
> sys.stderr.write("Please enable CONFIG_TRACING in your kernel "
> "when using the option -t (default).\n"
> "If it is enabled, make {0} readable by the "
> - "current user.\n")
> + "current user.\n"
> + .format(PATH_DEBUGFS_TRACING))
> if options.tracepoints:
> sys.exit(1)
>
> - sys.stderr.write("Falling back to debugfs statistics!\n"
> + sys.stderr.write("Falling back to debugfs statistics!\n")
> options.debugfs = True
> sleep(5)
>
>
Thanks Fam, I'll send a pull request soon.
Paolo
prev parent reply other threads:[~2016-02-22 17:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 2:20 [Qemu-devel] [PATCH v2] scripts/kvm/kvm_stat: Fix missing right parantheses and ".format(...)" Fam Zheng
2016-02-19 7:23 ` Janosch Frank
2016-02-22 17:29 ` Stefan Hajnoczi
2016-02-22 17:40 ` Paolo Bonzini
2016-02-25 11:22 ` Stefan Hajnoczi
2016-02-22 17:40 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CB481B.602@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=frankja@linux.vnet.ibm.com \
--cc=jjherne@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).