From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57839)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aXuTb-0000jg-Bm
	for qemu-devel@nongnu.org; Mon, 22 Feb 2016 12:40:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aXuTX-0008PU-37
	for qemu-devel@nongnu.org; Mon, 22 Feb 2016 12:40:51 -0500
Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]:35607)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aXuTW-0008PJ-Jy
	for qemu-devel@nongnu.org; Mon, 22 Feb 2016 12:40:46 -0500
Received: by mail-wm0-x236.google.com with SMTP id c200so183455163wme.0
	for <qemu-devel@nongnu.org>; Mon, 22 Feb 2016 09:40:46 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1455848416-13177-1-git-send-email-famz@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56CB481B.602@redhat.com>
Date: Mon, 22 Feb 2016 18:40:43 +0100
MIME-Version: 1.0
In-Reply-To: <1455848416-13177-1-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] scripts/kvm/kvm_stat: Fix missing right
 parantheses and ".format(...)"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Janosch Frank <frankja@linux.vnet.ibm.com>, "Jason J. Herne" <jjherne@linux.vnet.ibm.com>



On 19/02/2016 03:20, Fam Zheng wrote:
> They seem to have snuck in when applying Janosch Frank
> <frankja@linux.vnet.ibm.com>'s previous patch.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> 
> ---
> v2: Also fix .format. [Janosch]
> ---
>  scripts/kvm/kvm_stat | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
> index 3cf1181..769d884 100755
> --- a/scripts/kvm/kvm_stat
> +++ b/scripts/kvm/kvm_stat
> @@ -796,11 +796,12 @@ def check_access(options):
>          sys.stderr.write("Please enable CONFIG_TRACING in your kernel "
>                           "when using the option -t (default).\n"
>                           "If it is enabled, make {0} readable by the "
> -                         "current user.\n")
> +                         "current user.\n"
> +                         .format(PATH_DEBUGFS_TRACING))
>          if options.tracepoints:
>              sys.exit(1)
>  
> -        sys.stderr.write("Falling back to debugfs statistics!\n"
> +        sys.stderr.write("Falling back to debugfs statistics!\n")
>          options.debugfs = True
>          sleep(5)
>  
> 

Thanks Fam, I'll send a pull request soon.

Paolo