From: Richard Henderson <rth@twiddle.net>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH] target-i386: fix confusion in xcr0 bit position vs. mask
Date: Mon, 22 Feb 2016 11:14:44 -0800 [thread overview]
Message-ID: <56CB5E24.1010804@twiddle.net> (raw)
In-Reply-To: <1456136399-6227-1-git-send-email-pbonzini@redhat.com>
On 02/22/2016 02:19 AM, Paolo Bonzini wrote:
> The xsave and xrstor helpers are accessing the x86_ext_save_areas array
> using a bit mask instead of a bit position. Provide two sets of XSTATE_*
> definitions and use XSTATE_*_BIT when a bit position is requested.
Whoops. This patch is fine,
Reviewed-by: Richard Henderson <rth@twiddle.net>
Dosen't Eduardo have a pending patch set to make xsave use a struct? That
would fix this as well, by not requiring fpu_helper.c to use the
x86_ext_save_areas array at all...
r~
next prev parent reply other threads:[~2016-02-22 19:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 10:19 [Qemu-devel] [PATCH] target-i386: fix confusion in xcr0 bit position vs. mask Paolo Bonzini
2016-02-22 19:14 ` Richard Henderson [this message]
2016-02-22 21:56 ` Eduardo Habkost
2016-02-23 10:16 ` Paolo Bonzini
2016-02-23 18:50 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CB5E24.1010804@twiddle.net \
--to=rth@twiddle.net \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).