From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXvwe-0007ff-QN for qemu-devel@nongnu.org; Mon, 22 Feb 2016 14:14:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXvwb-00077F-KL for qemu-devel@nongnu.org; Mon, 22 Feb 2016 14:14:56 -0500 Received: from mail-qk0-x230.google.com ([2607:f8b0:400d:c09::230]:36349) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXvwb-000777-F3 for qemu-devel@nongnu.org; Mon, 22 Feb 2016 14:14:53 -0500 Received: by mail-qk0-x230.google.com with SMTP id s68so59456023qkh.3 for ; Mon, 22 Feb 2016 11:14:53 -0800 (PST) Sender: Richard Henderson References: <1456136399-6227-1-git-send-email-pbonzini@redhat.com> From: Richard Henderson Message-ID: <56CB5E24.1010804@twiddle.net> Date: Mon, 22 Feb 2016 11:14:44 -0800 MIME-Version: 1.0 In-Reply-To: <1456136399-6227-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-i386: fix confusion in xcr0 bit position vs. mask List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: ehabkost@redhat.com On 02/22/2016 02:19 AM, Paolo Bonzini wrote: > The xsave and xrstor helpers are accessing the x86_ext_save_areas array > using a bit mask instead of a bit position. Provide two sets of XSTATE_* > definitions and use XSTATE_*_BIT when a bit position is requested. Whoops. This patch is fine, Reviewed-by: Richard Henderson Dosen't Eduardo have a pending patch set to make xsave use a struct? That would fix this as well, by not requiring fpu_helper.c to use the x86_ext_save_areas array at all... r~