From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXxIo-0004Sn-HX for qemu-devel@nongnu.org; Mon, 22 Feb 2016 15:41:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXxIk-0004Zc-F5 for qemu-devel@nongnu.org; Mon, 22 Feb 2016 15:41:54 -0500 Received: from e18.ny.us.ibm.com ([129.33.205.208]:34312) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXxIk-0004Z7-AC for qemu-devel@nongnu.org; Mon, 22 Feb 2016 15:41:50 -0500 Received: from localhost by e18.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 22 Feb 2016 15:41:49 -0500 Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id D9B57C90042 for ; Mon, 22 Feb 2016 15:41:44 -0500 (EST) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u1MKflIH32440458 for ; Mon, 22 Feb 2016 20:41:47 GMT Received: from d01av01.pok.ibm.com (localhost [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u1MKfkTd030191 for ; Mon, 22 Feb 2016 15:41:47 -0500 References: <1456160797-832-1-git-send-email-mjrosato@linux.vnet.ibm.com> <1456160797-832-4-git-send-email-mjrosato@linux.vnet.ibm.com> <56CB46E3.8060907@suse.de> From: Matthew Rosato Message-ID: <56CB7287.3020100@linux.vnet.ibm.com> Date: Mon, 22 Feb 2016 15:41:43 -0500 MIME-Version: 1.0 In-Reply-To: <56CB46E3.8060907@suse.de> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v6 3/7] s390x/cpu: Move some CPU initialization into realize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Andreas_F=c3=a4rber?= , qemu-devel@nongnu.org Cc: borntraeger@de.ibm.com, agraf@suse.de, dahi@linux.vnet.ibm.com, pbonzini@redhat.com, bharata@linux.vnet.ibm.com, cornelia.huck@de.ibm.com, imammedo@redhat.com, rth@twiddle.net On 02/22/2016 12:35 PM, Andreas Färber wrote: > Am 22.02.2016 um 18:06 schrieb Matthew Rosato: >> In preparation for hotplug, defer some CPU initialization >> until the device is actually being realized. >> >> Signed-off-by: Matthew Rosato >> --- >> target-s390x/cpu.c | 9 ++++++--- >> 1 file changed, 6 insertions(+), 3 deletions(-) > > Looks reasonable on a brief sight, > > Reviewed-by: Andreas Färber > > What is env->cpu_num used for? In particular, have you thought about > linux-user creating multiple CPUs and possibly destroying them again? > env->cpu_num is intended to map to the s390x architecture concept of a cpu address, which is a numeric ID used to differentiate between CPUs when a targeted event occurs (like an unsolicited interrupt that must be handled on behalf of a particular CPU). s390x architecture currently cannot tolerate CPU destruction. Matt