From: hitmoon <zxq_yx_007@163.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Igor Mitsyanko" <i.mitsyanko@gmail.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Michael Walle" <michael@walle.cc>,
qemu-arm <qemu-arm@nongnu.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Guan Xuetao" <gxt@mprc.pku.edu.cn>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v4 5/9] hw/timer: QOM'ify m48txx_sysbus (pass 2)
Date: Tue, 23 Feb 2016 18:36:27 +0800 [thread overview]
Message-ID: <56CC362B.2080907@163.com> (raw)
In-Reply-To: <CAFEAcA_2eLMd39Duufk-u8VZ9UFnjPfqDFHo=QFk7qJaK4bCKQ@mail.gmail.com>
在 2016年02月23日 18:26, Peter Maydell 写道:
> On 23 February 2016 at 10:02, hitmoon <zxq_yx_007@163.com> wrote:
>> I still can NOT understand your intention properly. Can you explain more
>> clearly?
> VMState structures should generally mirror the structs
> they are saving/restoring. The M48txxISAState has an entry
> that just says "state is an M48t59State struct. Your
> VMState for M48txxISAState should therefore also have an
> entry saying "state is an M48t59State struct", it should
> not manually include all the fields in state. If you
> look for uses of VMSTATE_STRUCT in the codebase you'll
> find some examples.
>
> You also need to be able to test that migration works
> if you save data on a QEMU built before you make this change
> and then reload the data after it. So you need to find a test
> setup which uses this device (ie a working command line for
> a machine that uses it, preferably with a real guest) and make
> sure you can do vmsave/load.
>
> thanks
> -- PMM
Got it !
Thanks PMM !
prev parent reply other threads:[~2016-02-23 10:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 9:11 [Qemu-devel] [PATCH v4 5/9] hw/timer: QOM'ify m48txx_sysbus (pass 2) xiaoqiang zhao
2016-02-22 9:24 ` Peter Maydell
2016-02-22 10:28 ` hitmoon
2016-02-22 11:03 ` Peter Maydell
2016-02-22 11:24 ` xiaoqiang zhao
2016-02-22 11:25 ` xiaoqiang zhao
2016-02-23 5:11 ` hitmoon
2016-02-23 9:04 ` Peter Maydell
2016-02-23 10:02 ` hitmoon
2016-02-23 10:26 ` Peter Maydell
2016-02-23 10:36 ` hitmoon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CC362B.2080907@163.com \
--to=zxq_yx_007@163.com \
--cc=afaerber@suse.de \
--cc=edgar.iglesias@gmail.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=i.mitsyanko@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=michael@walle.cc \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).