From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42640) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYCqL-0003jF-Em for qemu-devel@nongnu.org; Tue, 23 Feb 2016 08:17:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYCqI-0000be-6N for qemu-devel@nongnu.org; Tue, 23 Feb 2016 08:17:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50441) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYCqI-0000ba-0R for qemu-devel@nongnu.org; Tue, 23 Feb 2016 08:17:30 -0500 References: <1456218099-386-1-git-send-email-xiecl.fnst@cn.fujitsu.com> <1456218099-386-2-git-send-email-xiecl.fnst@cn.fujitsu.com> From: Eric Blake Message-ID: <56CC5BE3.9090503@redhat.com> Date: Tue, 23 Feb 2016 06:17:23 -0700 MIME-Version: 1.0 In-Reply-To: <1456218099-386-2-git-send-email-xiecl.fnst@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nrHOwJrfbv0N2ojxgp7GHJSjLac7WpnoM" Subject: Re: [Qemu-devel] [PATCH v4 1/2] qmp event: Add QUORUM_FLUSH_ERROR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Changlong Xie , qemu devel , Alberto Garcia , Kevin Wolf , Max Reitz Cc: "Dr. David Alan Gilbert" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nrHOwJrfbv0N2ojxgp7GHJSjLac7WpnoM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/23/2016 02:01 AM, Changlong Xie wrote: > Signed-off-by: Wen Congyang > Signed-off-by: Changlong Xie > --- > block/quorum.c | 5 +++++ > docs/qmp-events.txt | 18 ++++++++++++++++++ > qapi/event.json | 16 ++++++++++++++++ > 3 files changed, 39 insertions(+) In addition to Berto's findings: > +++ b/docs/qmp-events.txt > @@ -340,6 +340,24 @@ Example: > =20 > Note: this event is rate-limited. > =20 > +QUORUM_FLUSH_ERROR > +----------------- Please keep the file sorted; this would fall between QUORUM_FAILURE and QUORUM_REPORT_BAD. Commit message should say why we need a third event, rather than reusing either of the other two (my guess: because you don't have a location, and don't want to modify the existing two to report a location - but why not just use 'sector-num':0, 'sectors-count': to report the entire file as the location?) Length of ---- separator should match text above it (you were off by one)= =2E Is this event rate-limited? Should it be? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nrHOwJrfbv0N2ojxgp7GHJSjLac7WpnoM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWzFvkAAoJEKeha0olJ0NqYJUH/jCr4pxlIpldzOgLuOv+xJHa z/Vpf+1nxn1ykgHtQ8IS24+tZEq02tI/9tns/nhUXnrarTZke8ieeDASX5EGxzIU SiJVF2Yb7iyfvVgGbNT2Yp7GzOTk1Z0GYLYPZeStjipvLTc0UH9ccGgZacclA3CV YDQG+NN81i3rxwARpStMDJ2jxsIMP6i0Tp4k/2UCcKve9z8Lv+1MN4udzuvx++3H xAiUGGrdzyg75N9mAwroR+gjOOQpZ5rKQUnIDl6XxHRBzT4HcflxW7iXYehrjDnr v8twJ6rhFUeZuStnTcG7qVpcHiDHuNURbeF5xaxws8QCZHKLIgbH4gK3IKMYlJw= =CGbJ -----END PGP SIGNATURE----- --nrHOwJrfbv0N2ojxgp7GHJSjLac7WpnoM--