From: Eric Blake <eblake@redhat.com>
To: Alberto Garcia <berto@igalia.com>,
Changlong Xie <xiecl.fnst@cn.fujitsu.com>,
qemu devel <qemu-devel@nongnu.org>, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 1/2] qmp event: Add QUORUM_FLUSH_ERROR
Date: Tue, 23 Feb 2016 06:45:49 -0700 [thread overview]
Message-ID: <56CC628D.7040909@redhat.com> (raw)
In-Reply-To: <w5137sj5zl2.fsf@maestria.local.igalia.com>
[-- Attachment #1: Type: text/plain, Size: 887 bytes --]
On 02/23/2016 06:24 AM, Alberto Garcia wrote:
> On Tue 23 Feb 2016 02:17:23 PM CET, Eric Blake wrote:
>
>> Commit message should say why we need a third event, rather than
>> reusing either of the other two (my guess: because you don't have a
>> location, and don't want to modify the existing two to report a
>> location - but why not just use 'sector-num':0, 'sectors-count':<size
>> of file> to report the entire file as the location?)
>
> I would also be fine with that solution.
I would also be fine if we added an optional enum member to the existing
event that said which operation failed ('read', 'write', 'flush') -
adding optional output members is safe, while converting existing
mandatory output members to optional may confuse existing clients.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-02-23 13:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 9:01 [Qemu-devel] [PATCH v4 0/2] modify vote rules for flush operation Changlong Xie
2016-02-23 9:01 ` [Qemu-devel] [PATCH v4 1/2] qmp event: Add QUORUM_FLUSH_ERROR Changlong Xie
2016-02-23 9:07 ` Changlong Xie
2016-02-23 12:53 ` Alberto Garcia
2016-02-23 13:17 ` Eric Blake
2016-02-23 13:24 ` Alberto Garcia
2016-02-23 13:45 ` Eric Blake [this message]
2016-02-23 14:05 ` Alberto Garcia
2016-02-24 2:49 ` Changlong Xie
2016-02-23 9:01 ` [Qemu-devel] [PATCH v4 2/2] quorum: modify vote rules for flush operation Changlong Xie
2016-02-23 12:56 ` Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CC628D.7040909@redhat.com \
--to=eblake@redhat.com \
--cc=berto@igalia.com \
--cc=dgilbert@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiecl.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).