From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Richard Henderson <rth@twiddle.net>, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 2/3] scripts/clean-includes: Ignore .inc.c files
Date: Tue, 23 Feb 2016 08:10:34 -0700 [thread overview]
Message-ID: <56CC766A.1070208@redhat.com> (raw)
In-Reply-To: <1456238983-10160-3-git-send-email-peter.maydell@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]
On 02/23/2016 07:49 AM, Peter Maydell wrote:
> Ignore files which have a .inc.c extension -- these are not headers
> but they are not standalone C source files either, so we can't make
> any automated decisions about what #include directives they should
> have.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> scripts/clean-includes | 5 +++++
> 1 file changed, 5 insertions(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/scripts/clean-includes b/scripts/clean-includes
> index 8a3f398..177d253 100755
> --- a/scripts/clean-includes
> +++ b/scripts/clean-includes
> @@ -94,6 +94,11 @@ EOT
>
> for f in "$@"; do
> case "$f" in
> + *.inc.c)
> + # These aren't standalone C source files
> + echo "SKIPPING $f (not a standalone source file)"
> + continue
> + ;;
> *.c)
> MODE=c
> ;;
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-02-23 15:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 14:49 [Qemu-devel] [PATCH 0/3] tcg: Rename tcg-target.c to tcg-target.inc.c Peter Maydell
2016-02-23 14:49 ` [Qemu-devel] [PATCH 1/3] " Peter Maydell
2016-02-23 14:49 ` [Qemu-devel] [PATCH 2/3] scripts/clean-includes: Ignore .inc.c files Peter Maydell
2016-02-23 15:10 ` Eric Blake [this message]
2016-02-23 14:49 ` [Qemu-devel] [PATCH 3/3] tcg: Remove unnecessary osdep.h includes from tcg-target.inc.c Peter Maydell
2016-02-23 15:40 ` [Qemu-devel] [PATCH 0/3] tcg: Rename tcg-target.c to tcg-target.inc.c Eric Blake
2016-02-23 16:19 ` Richard Henderson
2016-02-23 16:24 ` Peter Maydell
2016-02-23 16:34 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CC766A.1070208@redhat.com \
--to=eblake@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).