From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Richard Henderson <rth@twiddle.net>, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 0/3] tcg: Rename tcg-target.c to tcg-target.inc.c
Date: Tue, 23 Feb 2016 08:40:31 -0700 [thread overview]
Message-ID: <56CC7D6F.6040902@redhat.com> (raw)
In-Reply-To: <1456238983-10160-1-git-send-email-peter.maydell@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 889 bytes --]
On 02/23/2016 07:49 AM, Peter Maydell wrote:
> This patchset renames the arch-specific tcg-target.c files
> to tcg-target.inc.c, to better indicate the fact that they
> are not standalone source files but are just #included
> from another .c file.
>
> Having done that we can teach clean-includes about the .inc.c
> convention, and then undo some unnecessary #includes that it
> added earlier.
>
> thanks
> -- PMM
>
> Peter Maydell (3):
> tcg: Rename tcg-target.c to tcg-target.inc.c
> scripts/clean-includes: Ignore .inc.c files
> tcg: Remove unnecessary osdep.h includes from tcg-target.inc.c
Reviewed-by: Eric Blake <eblake@redhat.com>
also, for this series and for "post-include-cleanup followups":
Tested-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-02-23 15:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 14:49 [Qemu-devel] [PATCH 0/3] tcg: Rename tcg-target.c to tcg-target.inc.c Peter Maydell
2016-02-23 14:49 ` [Qemu-devel] [PATCH 1/3] " Peter Maydell
2016-02-23 14:49 ` [Qemu-devel] [PATCH 2/3] scripts/clean-includes: Ignore .inc.c files Peter Maydell
2016-02-23 15:10 ` Eric Blake
2016-02-23 14:49 ` [Qemu-devel] [PATCH 3/3] tcg: Remove unnecessary osdep.h includes from tcg-target.inc.c Peter Maydell
2016-02-23 15:40 ` Eric Blake [this message]
2016-02-23 16:19 ` [Qemu-devel] [PATCH 0/3] tcg: Rename tcg-target.c to tcg-target.inc.c Richard Henderson
2016-02-23 16:24 ` Peter Maydell
2016-02-23 16:34 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CC7D6F.6040902@redhat.com \
--to=eblake@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).