* [Qemu-devel] [PATCH] target-tricore: fix save_context_upper using env->PSW
@ 2016-02-19 13:46 Bastian Koppelmann
2016-02-23 19:54 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Bastian Koppelmann @ 2016-02-19 13:46 UTC (permalink / raw)
To: qemu-devel; +Cc: kbastian
If the cached bits for C, V, SV, AV, or SAV were set, they would
not be saved during the context save since env->PSW was stored instead
of properly reading them using psw_read().
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
---
target-tricore/op_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-tricore/op_helper.c b/target-tricore/op_helper.c
index 3aa6326..796fe67 100644
--- a/target-tricore/op_helper.c
+++ b/target-tricore/op_helper.c
@@ -2279,7 +2279,7 @@ static bool cdc_zero(target_ulong *psw)
static void save_context_upper(CPUTriCoreState *env, int ea)
{
cpu_stl_data(env, ea, env->PCXI);
- cpu_stl_data(env, ea+4, env->PSW);
+ cpu_stl_data(env, ea+4, psw_read(env));
cpu_stl_data(env, ea+8, env->gpr_a[10]);
cpu_stl_data(env, ea+12, env->gpr_a[11]);
cpu_stl_data(env, ea+16, env->gpr_d[8]);
--
2.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] target-tricore: fix save_context_upper using env->PSW
2016-02-19 13:46 [Qemu-devel] [PATCH] target-tricore: fix save_context_upper using env->PSW Bastian Koppelmann
@ 2016-02-23 19:54 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2016-02-23 19:54 UTC (permalink / raw)
To: Bastian Koppelmann, qemu-devel
On 02/19/2016 05:46 AM, Bastian Koppelmann wrote:
> If the cached bits for C, V, SV, AV, or SAV were set, they would
> not be saved during the context save since env->PSW was stored instead
> of properly reading them using psw_read().
>
> Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> ---
> target-tricore/op_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-23 19:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-19 13:46 [Qemu-devel] [PATCH] target-tricore: fix save_context_upper using env->PSW Bastian Koppelmann
2016-02-23 19:54 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).