From: "Denis V. Lunev" <den@openvz.org>
To: Amit Shah <amit.shah@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <famz@redhat.com>,
qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/2] move qcow2_invalidate_cache() out of coroutine context
Date: Wed, 24 Feb 2016 11:32:19 +0300 [thread overview]
Message-ID: <56CD6A93.8050403@openvz.org> (raw)
In-Reply-To: <20160224082212.GK10967@grmbl.mre>
On 02/24/2016 11:22 AM, Amit Shah wrote:
> On (Tue) 23 Feb 2016 [18:49:00], Denis V. Lunev wrote:
>> There is a possibility to hit an assert in qcow2_get_specific_info that
>> s->qcow_version is undefined. This happens when VM in starting from
>> suspended state, i.e. it processes incoming migration, and in the same
>> time 'info block' is called.
>>
>> The problem is that qcow2_invalidate_cache() closes the image and
>> memset()s BDRVQcowState in the middle.
>>
>> This operation should not be performed in coroutine context.
>>
>> Changes from v2:
>> - subject lines in patches
> Denis, did you see the comment by Fam to your patches?
>
> Amit
oops, I have seen it but have forgotten :( This should be fixed in a
perfect world. Though this code is called not frequently
and the amount of data lost is not that big.
OK, I'll rework this. Sorry :(
prev parent reply other threads:[~2016-02-24 8:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 15:49 [Qemu-devel] [PATCH v3 0/2] move qcow2_invalidate_cache() out of coroutine context Denis V. Lunev
2016-02-23 15:49 ` [Qemu-devel] [PATCH 1/2] migration (ordinary): move bdrv_invalidate_cache_all of " Denis V. Lunev
2016-02-23 15:49 ` [Qemu-devel] [PATCH 2/2] migration (postcopy): " Denis V. Lunev
2016-02-24 8:22 ` [Qemu-devel] [PATCH v3 0/2] move qcow2_invalidate_cache() out " Amit Shah
2016-02-24 8:32 ` Denis V. Lunev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CD6A93.8050403@openvz.org \
--to=den@openvz.org \
--cc=amit.shah@redhat.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).