From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49155)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1aYUs8-0004Is-F7
	for qemu-devel@nongnu.org; Wed, 24 Feb 2016 03:32:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1aYUs3-0008Rl-Cr
	for qemu-devel@nongnu.org; Wed, 24 Feb 2016 03:32:36 -0500
Received: from mx2.parallels.com ([199.115.105.18]:59665)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1aYUs3-0008Rg-6X
	for qemu-devel@nongnu.org; Wed, 24 Feb 2016 03:32:31 -0500
References: <1456242542-14042-1-git-send-email-den@openvz.org>
	<20160224082212.GK10967@grmbl.mre>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <56CD6A93.8050403@openvz.org>
Date: Wed, 24 Feb 2016 11:32:19 +0300
MIME-Version: 1.0
In-Reply-To: <20160224082212.GK10967@grmbl.mre>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 0/2] move qcow2_invalidate_cache() out
 of coroutine context
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>

On 02/24/2016 11:22 AM, Amit Shah wrote:
> On (Tue) 23 Feb 2016 [18:49:00], Denis V. Lunev wrote:
>> There is a possibility to hit an assert in qcow2_get_specific_info that
>> s->qcow_version is undefined. This happens when VM in starting from
>> suspended state, i.e. it processes incoming migration, and in the same
>> time 'info block' is called.
>>
>> The problem is that qcow2_invalidate_cache() closes the image and
>> memset()s BDRVQcowState in the middle.
>>
>> This operation should not be performed in coroutine context.
>>
>> Changes from v2:
>> - subject lines in patches
> Denis, did you see the comment by Fam to your patches?
>
> 		Amit
oops, I have seen it but have forgotten :( This should be fixed in a
perfect world. Though this code is called not frequently
and the amount of data lost is not that big.

OK, I'll rework this. Sorry :(