From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47963) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYcfe-00069n-DV for qemu-devel@nongnu.org; Wed, 24 Feb 2016 11:52:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYcfa-0003xG-CS for qemu-devel@nongnu.org; Wed, 24 Feb 2016 11:52:14 -0500 Received: from resqmta-ch2-11v.sys.comcast.net ([69.252.207.43]:44172) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYcfa-0003x2-7m for qemu-devel@nongnu.org; Wed, 24 Feb 2016 11:52:10 -0500 References: <1456273021-17473-1-git-send-email-jsnow@redhat.com> <1456273021-17473-3-git-send-email-jsnow@redhat.com> <20160224002757.GA749@ad.usersys.redhat.com> <56CCFD38.5040704@redhat.com> <56CCFEE8.1080109@redhat.com> From: Eric Blake Message-ID: <56CDDF28.7020001@redhat.com> Date: Wed, 24 Feb 2016 09:49:44 -0700 MIME-Version: 1.0 In-Reply-To: <56CCFEE8.1080109@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SApEAumDhfrVMiMiPCiFiqgbp0ijpfIeQ" Subject: Re: [Qemu-devel] [PATCH v3 2/3] block/backup: avoid copying less than full target clusters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , Fam Zheng Cc: kwolf@redhat.com, qemu-block@nongnu.org, jcody@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SApEAumDhfrVMiMiPCiFiqgbp0ijpfIeQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/23/2016 05:52 PM, John Snow wrote: > "Couldn't determine the cluster size of the target image, which has no > backing file" is more correct. The problem is not why we couldn't > determine it, but instead that we were unable to AND there is no backin= g > file, so our inability to determine it is a problem. >=20 > What's our policy on error message strings that eclipse 80 columns? I > was told once (at gunpoint; I live in the USA) to never split up long > strings because it makes them harder to grep for. I don't mind error messages longer than 80 columns; and I also don't mind string concatenation to fit the source of the message into reasonable lengths (when I grep for a message, I just grep for the first few words, not the whole message, precisely so that line wraps later in the message don't cause me grief). There's varying opinions from other contributors on whether an error message can be split, but I don't see anything in HACKING that says which style must prevail. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --SApEAumDhfrVMiMiPCiFiqgbp0ijpfIeQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWzd8oAAoJEKeha0olJ0NqKA4H/A8ulEPD1KPYhJyH0lq2zyxg vO2k3WoTPgibPcCJQRDkpnixN5FXIGGIu1pStglh0becECcxvKcTQyinZ4/Ej+Sa drI3y3ZBWKBdbRZ95AIPGEjexL9GskleJYbFxHKwNwH83awu+DU+oCX7/s3qA8VX JtyzW0ZSXqi9xsM8xTi8mRFic/lIL5KsO8hwB+88gc1lZSHhcKFTgdq24jkVsRyN OJ1C1M+l+rZQbc8QMa+9AFWbXnJA+gXxVMDe63EOpUMDGAmuDavDqBeHno+GPYWe 8cBQFTwYLG+WloSY52kvoNh8v+7n7tH5+J9Qi3bRC4FXl+ltg08R34AAeUUjOQg= =Y4vY -----END PGP SIGNATURE----- --SApEAumDhfrVMiMiPCiFiqgbp0ijpfIeQ--