From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYcoc-00035U-Hs for qemu-devel@nongnu.org; Wed, 24 Feb 2016 12:01:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYcoZ-0006xV-9Q for qemu-devel@nongnu.org; Wed, 24 Feb 2016 12:01:30 -0500 Received: from resqmta-po-08v.sys.comcast.net ([96.114.154.167]:46084) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYcoZ-0006xJ-3K for qemu-devel@nongnu.org; Wed, 24 Feb 2016 12:01:27 -0500 References: <1456308715-15465-1-git-send-email-xiecl.fnst@cn.fujitsu.com> <1456308715-15465-3-git-send-email-xiecl.fnst@cn.fujitsu.com> From: Eric Blake Message-ID: <56CDE156.3020703@redhat.com> Date: Wed, 24 Feb 2016 09:59:02 -0700 MIME-Version: 1.0 In-Reply-To: <1456308715-15465-3-git-send-email-xiecl.fnst@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LoKLHoIgfmVuT3AaaNsCJ5aP0lxklnQLE" Subject: Re: [Qemu-devel] [PATCH v5 2/3] qmp event: Refactor QUORUM_REPORT_BAD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Changlong Xie , qemu devel , Alberto Garcia , Kevin Wolf , Max Reitz , Markus Armbruster Cc: "Dr. David Alan Gilbert" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LoKLHoIgfmVuT3AaaNsCJ5aP0lxklnQLE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/24/2016 03:11 AM, Changlong Xie wrote: > Introduce QuorumOpType, and make QUORUM_REPORT_BAD compatible > with it. >=20 > Cc: Dr. David Alan Gilbert > Cc: Wen Congyang > Signed-off-by: Wen Congyang > Signed-off-by: Changlong Xie > --- > +++ b/docs/qmp-events.txt > @@ -307,6 +307,7 @@ Emitted to report a corruption of a Quorum file. > =20 > Data: > =20 > +- "type": Quorum operation type (json-string, optional) I don't think 'type' needs to be optional, after all. Just always output it. > - "error": Error message (json-string, optional) > Only present on failure. This field contains a hum= an-readable > error message. There are no semantics other than t= hat the > @@ -318,10 +319,17 @@ Data: > =20 > Example: > =20 > +Read/Write operation: > { "event": "QUORUM_REPORT_BAD", > "data": { "node-name": "node0", "sector-num": 345435, "sectors-co= unt": 5 }, > "timestamp": { "seconds": 1344522075, "microseconds": 745528 } } and this example would then show "type":"read" --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LoKLHoIgfmVuT3AaaNsCJ5aP0lxklnQLE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWzeFWAAoJEKeha0olJ0NqpLMIAIOjoT3ar/6oK0MzPAIuJrSt o9S9VDu5Nn1IG7LMVESAobndN97892VPDk6fkaFet1PFiB/VAeLE6R57LBVU3Si8 93NCaNgwLCeugGkXlwRg/O2eqiBradCMFzlmDPGXFFWH9njA+b6m9Fds1vERNADk kYwp+zqmyGzfvWZNRk9lGreaIQRSJy1njWawHXs7iR5UG3aoIMuvWlLN6UnCkzAh i7TCu3sk5sZ9Yo3hG7fcG6LF1SESlE3LJAnJG3aiYmKJGRVZQL8mRc95UYVa0poc BiM6c7qfyu2xypEoMzN+qccTskxFRjXz84qnmS+vkHoNerX0ZY//G/RCTHJfcF0= =ww/u -----END PGP SIGNATURE----- --LoKLHoIgfmVuT3AaaNsCJ5aP0lxklnQLE--