From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYf8I-0007Bx-IT for qemu-devel@nongnu.org; Wed, 24 Feb 2016 14:29:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYf8E-0002xz-IK for qemu-devel@nongnu.org; Wed, 24 Feb 2016 14:29:58 -0500 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:33867 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYf8E-0002xi-7l for qemu-devel@nongnu.org; Wed, 24 Feb 2016 14:29:54 -0500 Message-ID: <56CE04B0.8020408@kamp.de> Date: Wed, 24 Feb 2016 20:29:52 +0100 From: Peter Lieven MIME-Version: 1.0 References: <951bf8f8c49ff3c2a38dcd02fe78ae00a5de8add.1456274059.git.jcody@redhat.com> <20160224101937.GC4485@noname.redhat.com> <20160224122443.GC23671@localhost.localdomain> <20160224130718.GE4485@noname.redhat.com> In-Reply-To: <20160224130718.GE4485@noname.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] block/vpc: give option to force the current_size field in .bdrv_create List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Jeff Cody , qemu-devel@nongnu.org, qemu-block@nongnu.org Am 24.02.2016 um 14:07 schrieb Kevin Wolf: > Am 24.02.2016 um 13:44 hat Peter Lieven geschrieben: >> if the size is forced I would set the chs values to max. this way no >> new creator String is needed and it is even backwards compatible. this >> is what disk2vhd does. > Does disk2vhd do it this way even if the size is smaller than the > maximum that can be represented with CHS? Afaik it always sets it to MAX. This is why we first introduced a check for the d2v creator in Qemu because all VHD Images created by disk2vhd where 127GB regardless of their size. Peter