From: Eric Blake <eblake@redhat.com>
To: Wen Congyang <wency@cn.fujitsu.com>,
Changlong Xie <xiecl.fnst@cn.fujitsu.com>,
qemu devel <qemu-devel@nongnu.org>,
Alberto Garcia <berto@igalia.com>, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 2/3] qmp event: Refactor QUORUM_REPORT_BAD
Date: Wed, 24 Feb 2016 18:12:05 -0700 [thread overview]
Message-ID: <56CE54E5.8060509@redhat.com> (raw)
In-Reply-To: <56CE4FC8.5060605@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 651 bytes --]
On 02/24/2016 05:50 PM, Wen Congyang wrote:
>>> +- "type": Quorum operation type (json-string, optional)
>>
>> I don't think 'type' needs to be optional, after all. Just always
>> output it.
>
> If we output read/write type, old libvirt will ignore the read/write error events?
The QMP protocol already documents that ALL clients MUST ignore
unexpected output fields. Any client that is unprepared for new fields
appearing in the dictionary is buggy. Libvirt will be just fine if you
output a new "type":"read".
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-02-25 1:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 10:11 [Qemu-devel] [PATCH v5 0/3] modify vote rules for flush operation Changlong Xie
2016-02-24 10:11 ` [Qemu-devel] [PATCH v5 1/3] docs: fix invalid node name in qmp event Changlong Xie
2016-02-24 10:21 ` Alberto Garcia
2016-02-24 10:11 ` [Qemu-devel] [PATCH v5 2/3] qmp event: Refactor QUORUM_REPORT_BAD Changlong Xie
2016-02-24 12:35 ` Alberto Garcia
2016-02-24 16:57 ` Eric Blake
2016-02-25 2:44 ` Changlong Xie
2016-02-24 16:59 ` Eric Blake
2016-02-25 0:50 ` Wen Congyang
2016-02-25 1:12 ` Eric Blake [this message]
2016-02-25 1:24 ` Changlong Xie
2016-02-24 10:11 ` [Qemu-devel] [PATCH v5 3/3] quorum: modify vote rules for flush operation Changlong Xie
2016-02-24 12:38 ` Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CE54E5.8060509@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=dgilbert@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wency@cn.fujitsu.com \
--cc=xiecl.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).