From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYkTS-0002cR-SL for qemu-devel@nongnu.org; Wed, 24 Feb 2016 20:12:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYkTP-0000ia-N0 for qemu-devel@nongnu.org; Wed, 24 Feb 2016 20:12:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49557) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYkTP-0000i8-HZ for qemu-devel@nongnu.org; Wed, 24 Feb 2016 20:12:07 -0500 References: <1456308715-15465-1-git-send-email-xiecl.fnst@cn.fujitsu.com> <1456308715-15465-3-git-send-email-xiecl.fnst@cn.fujitsu.com> <56CDE156.3020703@redhat.com> <56CE4FC8.5060605@cn.fujitsu.com> From: Eric Blake Message-ID: <56CE54E5.8060509@redhat.com> Date: Wed, 24 Feb 2016 18:12:05 -0700 MIME-Version: 1.0 In-Reply-To: <56CE4FC8.5060605@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3xuSFfbLtNqTr1Vi93i2DrJceTg3keIWh" Subject: Re: [Qemu-devel] [PATCH v5 2/3] qmp event: Refactor QUORUM_REPORT_BAD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wen Congyang , Changlong Xie , qemu devel , Alberto Garcia , Kevin Wolf , Max Reitz , Markus Armbruster Cc: "Dr. David Alan Gilbert" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3xuSFfbLtNqTr1Vi93i2DrJceTg3keIWh Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/24/2016 05:50 PM, Wen Congyang wrote: >>> +- "type": Quorum operation type (json-string, optional) >> >> I don't think 'type' needs to be optional, after all. Just always >> output it. >=20 > If we output read/write type, old libvirt will ignore the read/write er= ror events? The QMP protocol already documents that ALL clients MUST ignore unexpected output fields. Any client that is unprepared for new fields appearing in the dictionary is buggy. Libvirt will be just fine if you output a new "type":"read". --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --3xuSFfbLtNqTr1Vi93i2DrJceTg3keIWh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWzlTlAAoJEKeha0olJ0NqEQoIAIo9qy4U/SjbxBtZPdonZR0J 0MtanyRHVeLLXOyxwvoUIxT14p3FsHfF3O69Kwbear1b3Jrs+ho5M6CbLHv+P2Ao I2NmLTBW1H3ZGtAW+mimm3EB2JBpk67fUJbq10ZMFqNx5XlFwuf6vigC+PK7R2+r glTwQunqerLpQMSlxqfMImPgH6touMVfuQVVXukBcXMODhzqVQEslUgcQiPl7HTl IkYoUa0/dhnDoMWvYXHkzdjcVCQ97enpdZU6Q7Eav9ybphTwNBnOyVSilAoFwM0g 7t7gBlz2Y+xi9bbSiCku9fhYEiuViia26u+bP8s8xvVZ86FUc/DlHrbJIHj49OY= =WstL -----END PGP SIGNATURE----- --3xuSFfbLtNqTr1Vi93i2DrJceTg3keIWh--