From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYkV1-0004NO-AW for qemu-devel@nongnu.org; Wed, 24 Feb 2016 20:13:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYkUy-0001Ii-4S for qemu-devel@nongnu.org; Wed, 24 Feb 2016 20:13:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36994) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYkUx-0001Hv-UX for qemu-devel@nongnu.org; Wed, 24 Feb 2016 20:13:44 -0500 References: <1456362069-13087-1-git-send-email-mdroth@linux.vnet.ibm.com> From: Eric Blake Message-ID: <56CE5546.9010801@redhat.com> Date: Wed, 24 Feb 2016 18:13:42 -0700 MIME-Version: 1.0 In-Reply-To: <1456362069-13087-1-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="J0lCMsFoOCxKLFEeTcincfPfW3tIcqPQA" Subject: Re: [Qemu-devel] [PATCH] qga: fix w32 breakage due to missing osdep.h includes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth , qemu-devel@nongnu.org Cc: Peter Maydell This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --J0lCMsFoOCxKLFEeTcincfPfW3tIcqPQA Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/24/2016 06:01 PM, Michael Roth wrote: > requester.h relied on qemu/compiler.h definitions to > handle GCC_FMT_ATTR() stub, but this include was removed as part > of scripted clean-ups via 30456d5: >=20 > all: Clean up includes >=20 > under the assumption that all C files would have included it via > qemu/osdep.h at that point. requester.cpp was likely missed > due to C++ files requiring manual/special handling as well as > VSS build options needing to be enabled to trigger build failures. >=20 > Fix this by including qemu/osdep.h. That in turn pulls in a > macro from qapi/error.h that conflicts with a struct field name > in requester.h, so fix that as well by renaming the field. >=20 > While we're at it, fix up provider.cpp/install.cpp to include > osdep.h as well. >=20 > Cc: Peter Maydell > Signed-off-by: Michael Roth > --- Reviewed-by: Eric Blake (but I'm not set up to provide Tested-by on this one) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --J0lCMsFoOCxKLFEeTcincfPfW3tIcqPQA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWzlVGAAoJEKeha0olJ0NqHMQIAK+OSjYbyK7Ca4Xk1h69eStP aH8ENj9PV8b9jrtQZnwFMQgvoj3mOlQQqQ5WPAJngy1OM0wuHqf/faYstucTBv9z 6P1qwwFyiG6PH6iGfMLr140aFWw70yv6iFTZ+a8htyi24k7hgqeIhd71Dikyv5LT IGjYANI9H+ruinU40N1hArh3OD0JCNqtwGgEpi3XdvVa71teY9TUN6pBgughhn7H Ko8Gbi5eWFkvUn6LuRBrYuoJpnvCe9kuR8j9I0OjrLRrwRXWDeWz3UrBN4/f+9OC LdHjIrnxx3t82l8dK12fKZf5uKhs6MdGMzQzP+2XBUXMyXHBfWXHu6SD/T/UGMc= =8wzG -----END PGP SIGNATURE----- --J0lCMsFoOCxKLFEeTcincfPfW3tIcqPQA--