From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33972)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vsementsov@virtuozzo.com>) id 1aYsdK-0006Vw-WA
	for qemu-devel@nongnu.org; Thu, 25 Feb 2016 04:54:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <vsementsov@virtuozzo.com>) id 1aYsdG-00086X-VE
	for qemu-devel@nongnu.org; Thu, 25 Feb 2016 04:54:54 -0500
Received: from mx2.parallels.com ([199.115.105.18]:47392)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vsementsov@virtuozzo.com>) id 1aYsdG-00086G-Nz
	for qemu-devel@nongnu.org; Thu, 25 Feb 2016 04:54:50 -0500
Message-ID: <56CECF63.5060002@virtuozzo.com>
Date: Thu, 25 Feb 2016 12:54:43 +0300
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
MIME-Version: 1.0
References: <1456343639-3471-1-git-send-email-mst@redhat.com>
	<1456343639-3471-6-git-send-email-mst@redhat.com>
	<56CEA6BE.60504@virtuozzo.com>
	<20160225102409-mutt-send-email-mst@redhat.com>
	<56CEC19C.4020400@virtuozzo.com>
	<20160225110947-mutt-send-email-mst@redhat.com>
In-Reply-To: <20160225110947-mutt-send-email-mst@redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 05/23] pc-dimm: add pc_dimm_build_list()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>

On 25.02.2016 12:11, Michael S. Tsirkin wrote:
> On Thu, Feb 25, 2016 at 11:55:56AM +0300, Vladimir Sementsov-Ogievskiy wrote:
>> On 25.02.2016 11:39, Michael S. Tsirkin wrote:
>>> On Thu, Feb 25, 2016 at 10:01:18AM +0300, Vladimir Sementsov-Ogievskiy wrote:
>>>> Stop!
>>> It builds fine here. Did you check out my tree?
>> anyway, this file should be here, as it is added into Makefile:
>>
>> --- a/stubs/Makefile.objs
>> +++ b/stubs/Makefile.objs
>> @@ -35,7 +35,7 @@ stub-obj-y += vmstate.o
>>   stub-obj-$(CONFIG_WIN32) += fd-register.o
>>   stub-obj-y += cpus.o
>>   stub-obj-y += kvm.o
>> -stub-obj-y += qmp_pc_dimm_device_list.o
>> +stub-obj-y += pc_dimm.o
>>   stub-obj-y += target-monitor-defs.o
>>   stub-obj-y += target-get-monitor-def.o
>>   stub-obj-y += vhost.o
>>
> Hmm that's right.
> Thanks!
> Looks like it was picking up an old object in the filesystem :(
> I'll respin - for now, does everything work for you if you drop
> this line from the makefile?

it will break compilation for targets without memory hotplug, it was 
discussed on list. stubs are necessary.

>
>> ===========
>> git clone git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tmp
>> cd tmp/
>> git checkout for_upstream
>> ./configure  --target-list=x86_64-softmmu
>> make -j9
>>> make: *** No rule to make target `stubs/pc_dimm.o', needed by
>> `libqemustub.a'.  Stop


-- 
Best regards,
Vladimir