From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYsrL-0008OP-T3 for qemu-devel@nongnu.org; Thu, 25 Feb 2016 05:09:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYsrI-0003o8-2q for qemu-devel@nongnu.org; Thu, 25 Feb 2016 05:09:23 -0500 Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:37653) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYsrH-0003o4-Rh for qemu-devel@nongnu.org; Thu, 25 Feb 2016 05:09:20 -0500 Received: by mail-wm0-x234.google.com with SMTP id g62so20308281wme.0 for ; Thu, 25 Feb 2016 02:09:19 -0800 (PST) Sender: Paolo Bonzini References: <1456343639-3471-1-git-send-email-mst@redhat.com> <1456343639-3471-6-git-send-email-mst@redhat.com> <56CEA6BE.60504@virtuozzo.com> <20160225102409-mutt-send-email-mst@redhat.com> <56CEC19C.4020400@virtuozzo.com> <20160225110947-mutt-send-email-mst@redhat.com> <56CECF63.5060002@virtuozzo.com> From: Paolo Bonzini Message-ID: <56CED2CC.3040208@redhat.com> Date: Thu, 25 Feb 2016 11:09:16 +0100 MIME-Version: 1.0 In-Reply-To: <56CECF63.5060002@virtuozzo.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 05/23] pc-dimm: add pc_dimm_build_list() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , "Michael S. Tsirkin" Cc: Peter Maydell , qemu-devel@nongnu.org, Igor Mammedov On 25/02/2016 10:54, Vladimir Sementsov-Ogievskiy wrote: > On 25.02.2016 12:11, Michael S. Tsirkin wrote: >> On Thu, Feb 25, 2016 at 11:55:56AM +0300, Vladimir Sementsov-Ogievskiy >> wrote: >>> On 25.02.2016 11:39, Michael S. Tsirkin wrote: >>>> On Thu, Feb 25, 2016 at 10:01:18AM +0300, Vladimir >>>> Sementsov-Ogievskiy wrote: >>>>> Stop! >>>> It builds fine here. Did you check out my tree? >>> anyway, this file should be here, as it is added into Makefile: >>> >>> --- a/stubs/Makefile.objs >>> +++ b/stubs/Makefile.objs >>> @@ -35,7 +35,7 @@ stub-obj-y += vmstate.o >>> stub-obj-$(CONFIG_WIN32) += fd-register.o >>> stub-obj-y += cpus.o >>> stub-obj-y += kvm.o >>> -stub-obj-y += qmp_pc_dimm_device_list.o >>> +stub-obj-y += pc_dimm.o >>> stub-obj-y += target-monitor-defs.o >>> stub-obj-y += target-get-monitor-def.o >>> stub-obj-y += vhost.o >>> >> Hmm that's right. >> Thanks! >> Looks like it was picking up an old object in the filesystem :( >> I'll respin - for now, does everything work for you if you drop >> this line from the makefile? > > it will break compilation for targets without memory hotplug, it was > discussed on list. stubs are necessary. mst, indeed it's not clear to me why you're deleting qmp_pc_dimm_device_list.c... On the other hand, pc_dimm_build_list doesn't need a stub. Just put it in hw/virtio/virtio-balloon.c. Paolo > >> >>> =========== >>> git clone git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tmp >>> cd tmp/ >>> git checkout for_upstream >>> ./configure --target-list=x86_64-softmmu >>> make -j9 >>>> make: *** No rule to make target `stubs/pc_dimm.o', needed by >>> `libqemustub.a'. Stop > >