From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYu5L-0000gY-0k for qemu-devel@nongnu.org; Thu, 25 Feb 2016 06:27:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYu5I-00076s-5G for qemu-devel@nongnu.org; Thu, 25 Feb 2016 06:27:54 -0500 References: <20160225110800.23227.19534.stgit@bahia.huguette.org> From: Thomas Huth Message-ID: <56CEE534.2070802@redhat.com> Date: Thu, 25 Feb 2016 12:27:48 +0100 MIME-Version: 1.0 In-Reply-To: <20160225110800.23227.19534.stgit@bahia.huguette.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spapr_rng: disable hotpluggability List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz , David Gibson Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 25.02.2016 12:08, Greg Kurz wrote: > It is currently possible to hotplug a spapr_rng device but QEMU crashes > when we try to hot unplug: > > ERROR:hw/core/qdev.c:295:qdev_unplug: assertion failed: (hotplug_ctrl) > Aborted > > This happens because spapr_rng isn't plugged to any bus and sPAPR does > not provide hotplug support for it: qdev_get_hotplug_handler() hence > return NULL and we hit the assertion. > > And anyway, it doesn't make much sense to unplug this device since hcalls > cannot be unregistered. Even the idea of hotplugging a RNG device instead > of declaring it on the QEMU command line looks weird. > > This patch simply disables hotpluggability for the spapr-rng class. > > Signed-off-by: Greg Kurz > --- > hw/ppc/spapr_rng.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/ppc/spapr_rng.c b/hw/ppc/spapr_rng.c > index 8484fcf54774..a39d472b66fd 100644 > --- a/hw/ppc/spapr_rng.c > +++ b/hw/ppc/spapr_rng.c > @@ -170,6 +170,7 @@ static void spapr_rng_class_init(ObjectClass *oc, void *data) > dc->realize = spapr_rng_realize; > set_bit(DEVICE_CATEGORY_MISC, dc->categories); > dc->props = spapr_rng_properties; > + dc->hotpluggable = false; > } That makes sense! Reviewed-by: Thomas Huth