From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PULL 4/8] spice: reset cursor on resize
Date: Fri, 26 Feb 2016 00:10:16 +0100 [thread overview]
Message-ID: <56CF89D8.5020101@redhat.com> (raw)
In-Reply-To: <1456237462-3687-5-git-send-email-kraxel@redhat.com>
On 23/02/2016 15:24, Gerd Hoffmann wrote:
> qemu_mutex_lock(&ssd->lock);
> + if (c) {
> + cursor_get(c);
> + }
> + cursor_put(ssd->cursor);
> + ssd->cursor = c;
> ssd->hot_x = c->hot_x;
> ssd->hot_y = c->hot_y;
Coverity complains that this would dereference a NULL c, and I think
it's right; either an unlock+return is missing, or the "if" is unnecessary.
Paolo
next prev parent reply other threads:[~2016-02-25 23:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 14:24 [Qemu-devel] [PULL 0/8] spice: initial opengl/virgl support, postcopy migration fix Gerd Hoffmann
2016-02-23 14:24 ` [Qemu-devel] [PULL 1/8] spice: init dcl before registering qxl interface Gerd Hoffmann
2016-02-23 14:24 ` [Qemu-devel] [PULL 2/8] configure: add dma-buf support detection Gerd Hoffmann
2016-02-26 9:29 ` Paolo Bonzini
2016-02-29 11:00 ` Gerd Hoffmann
2016-02-23 14:24 ` [Qemu-devel] [PULL 3/8] egl-helpers: add functions for render nodes and dma-buf passing Gerd Hoffmann
2016-03-02 14:14 ` Paolo Bonzini
2016-02-23 14:24 ` [Qemu-devel] [PULL 4/8] spice: reset cursor on resize Gerd Hoffmann
2016-02-25 23:10 ` Paolo Bonzini [this message]
2016-02-25 23:23 ` Marc-André Lureau
2016-02-25 23:23 ` Paolo Bonzini
2016-02-23 14:24 ` [Qemu-devel] [PULL 5/8] spice: add opengl/virgl/dmabuf support Gerd Hoffmann
2016-02-23 14:24 ` [Qemu-devel] [PULL 6/8] spice/gl: add unblock timer Gerd Hoffmann
2016-02-23 14:24 ` [Qemu-devel] [PULL 7/8] spice/gl: tweak debug messages Gerd Hoffmann
2016-02-23 14:24 ` [Qemu-devel] [PULL 8/8] Postcopy+spice: Pass spice migration data earlier Gerd Hoffmann
2016-02-23 16:44 ` [Qemu-devel] [PULL 0/8] spice: initial opengl/virgl support, postcopy migration fix Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CF89D8.5020101@redhat.com \
--to=pbonzini@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).