From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41780)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1aZ73s-0004m3-0p
	for qemu-devel@nongnu.org; Thu, 25 Feb 2016 20:19:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1aZ73n-0004rR-6L
	for qemu-devel@nongnu.org; Thu, 25 Feb 2016 20:19:15 -0500
Received: from [59.151.112.132] (port=43491 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1aZ73m-0004nx-A6
	for qemu-devel@nongnu.org; Thu, 25 Feb 2016 20:19:11 -0500
Message-ID: <56CFA85D.4060408@cn.fujitsu.com>
Date: Fri, 26 Feb 2016 09:20:29 +0800
From: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
MIME-Version: 1.0
References: <1456378389-15648-1-git-send-email-xiecl.fnst@cn.fujitsu.com>
	<1456378389-15648-3-git-send-email-xiecl.fnst@cn.fujitsu.com>
	<w51mvqp12hn.fsf@maestria.local.igalia.com>
In-Reply-To: <w51mvqp12hn.fsf@maestria.local.igalia.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v6 2/3] qmp event: Refactor
	QUORUM_REPORT_BAD
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>, qemu devel <qemu-devel@nongnu.org>, Eric Blake <eblake@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>, Markus Armbruster <armbru@redhat.com>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

On 02/25/2016 06:57 PM, Alberto Garcia wrote:
> On Thu 25 Feb 2016 06:33:08 AM CET, Changlong Xie <xiecl.fnst@cn.fujitsu.com> wrote:
>> +Read/Write operation:
>>   { "event": "QUORUM_REPORT_BAD",
>> -     "data": { "node-name": "node0", "sector-num": 345435, "sectors-count": 5 },
>> +     "data": { "node-name": "node0", "sector-num": 345435, "sectors-count": 5,
>> +     "type": "read" },
>>        "timestamp": { "seconds": 1344522075, "microseconds": 745528 } }
>
> Since you introduced the 'type' field and this is now an example of a
> read error, you can change the description to say simply "Read
> operation:". In my opinion there's no need to add yet another example
> for a write operation, I think it's clear enough.

Ok

>
>> +Flush operation:
>> +{ "event": "QUORUM_REPORT_BAD",
>> +     "data": { "node-name": "node0", "sector-num": 0, "sectors-count": 2097120,
>> +     "type": "flush", "error": "Broken pipe" },
>> +     "timestamp": { "seconds": 1456406829, "microseconds": 291763 } }
>
> Here (and in the previous case) please indent "type" so it goes under

Surely.

> "node-name":
>
>     { "event": "QUORUM_REPORT_BAD",
>       "data": { "node-name": "node0", "sector-num": 0, "sectors-count": 2097120,
>                 "type": "flush", "error": "Broken pipe" },
>       "timestamp": { "seconds": 1456406829, "microseconds": 291763 } }
>
> Otherwise I think the patch looks perfect now. Thanks!
>

Thanks for your review. Will send another series.

Thanks
	-Xie

> Berto
>
>
> .
>