* [Qemu-devel] [PATCH] vhost-user: verify that number of queues is less than MAX_QUEUE_NUM
@ 2016-02-24 10:44 Ilya Maximets
2016-02-26 6:32 ` Jason Wang
0 siblings, 1 reply; 2+ messages in thread
From: Ilya Maximets @ 2016-02-24 10:44 UTC (permalink / raw)
To: qemu-devel; +Cc: Ilya Maximets, Jason Wang, Dyasly Sergey, Michael S. Tsirkin
Fix QEMU crash when -netdev vhost-user,queues=n is passed with number
of queues greater than MAX_QUEUE_NUM.
Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
---
net/vhost-user.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/vhost-user.c b/net/vhost-user.c
index 451dbbf..b753b3d 100644
--- a/net/vhost-user.c
+++ b/net/vhost-user.c
@@ -317,9 +317,10 @@ int net_init_vhost_user(const NetClientOptions *opts, const char *name,
}
queues = vhost_user_opts->has_queues ? vhost_user_opts->queues : 1;
- if (queues < 1) {
+ if (queues < 1 || queues > MAX_QUEUE_NUM) {
error_setg(errp,
- "vhost-user number of queues must be bigger than zero");
+ "vhost-user number of queues must be in range [1, %d]",
+ MAX_QUEUE_NUM);
return -1;
}
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] vhost-user: verify that number of queues is less than MAX_QUEUE_NUM
2016-02-24 10:44 [Qemu-devel] [PATCH] vhost-user: verify that number of queues is less than MAX_QUEUE_NUM Ilya Maximets
@ 2016-02-26 6:32 ` Jason Wang
0 siblings, 0 replies; 2+ messages in thread
From: Jason Wang @ 2016-02-26 6:32 UTC (permalink / raw)
To: Ilya Maximets, qemu-devel; +Cc: Dyasly Sergey, Michael S. Tsirkin
On 02/24/2016 06:44 PM, Ilya Maximets wrote:
> Fix QEMU crash when -netdev vhost-user,queues=n is passed with number
> of queues greater than MAX_QUEUE_NUM.
>
> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
> ---
> net/vhost-user.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/net/vhost-user.c b/net/vhost-user.c
> index 451dbbf..b753b3d 100644
> --- a/net/vhost-user.c
> +++ b/net/vhost-user.c
> @@ -317,9 +317,10 @@ int net_init_vhost_user(const NetClientOptions *opts, const char *name,
> }
>
> queues = vhost_user_opts->has_queues ? vhost_user_opts->queues : 1;
> - if (queues < 1) {
> + if (queues < 1 || queues > MAX_QUEUE_NUM) {
> error_setg(errp,
> - "vhost-user number of queues must be bigger than zero");
> + "vhost-user number of queues must be in range [1, %d]",
> + MAX_QUEUE_NUM);
> return -1;
> }
>
Acked-by: Jason Wang <jasowang@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-26 6:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-24 10:44 [Qemu-devel] [PATCH] vhost-user: verify that number of queues is less than MAX_QUEUE_NUM Ilya Maximets
2016-02-26 6:32 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).