From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52914)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1aZCUB-0004Oj-9t
	for qemu-devel@nongnu.org; Fri, 26 Feb 2016 02:06:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1aZCU7-0007WJ-A2
	for qemu-devel@nongnu.org; Fri, 26 Feb 2016 02:06:47 -0500
Received: from mx1.redhat.com ([209.132.183.28]:38079)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1aZCU7-0007WF-48
	for qemu-devel@nongnu.org; Fri, 26 Feb 2016 02:06:43 -0500
References: <1456296883-9173-1-git-send-email-zhangchen.fnst@cn.fujitsu.com>
	<56CD6506.3080604@redhat.com>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <56CFF971.8040705@redhat.com>
Date: Fri, 26 Feb 2016 15:06:25 +0800
MIME-Version: 1.0
In-Reply-To: <56CD6506.3080604@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V6 0/2] net/filter-mirror:add filter-mirror
 and unit test
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>, qemu devel <qemu-devel@nongnu.org>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>, Li Zhijian <lizhijian@cn.fujitsu.com>, Gui jianfeng <guijianfeng@cn.fujitsu.com>, "eddie.dong" <eddie.dong@intel.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Yang Hongyang <hongyang.yang@easystack.cn>



On 02/24/2016 04:08 PM, Jason Wang wrote:
>
> On 02/24/2016 02:54 PM, Zhang Chen wrote:
>> Filter-mirror is a netfilter plugin.
>> It gives qemu the ability to mirror
>> packets to a chardev.
>>
>> v6:
>>  - Address Jason's comments.
>>
>> v5:
>>  - Address Jason's comments.
>>
>> v4:
>>  - Address Jason's comments.
>>
>> v3:
>>  - Add filter-mirror unit test according
>>    to Jason's comments
>>  - Address zhanghailiang's comments.
>>  - Address Jason's comments.
>>
>> v2:
>>  - Address zhanghailiang's comments.
>>  - Address Eric Blake's comments.
>>  - Address Yang Hongyang's comments.
>>  - Address Dave's comments.
>>
>> v1:
>>  initial patch.
>>
>>
>> Zhang Chen (2):
>>   net/filter-mirror:Add filter-mirror
>>   tests/test-filter-mirror:add filter-mirror unit test
>>
>>  net/Makefile.objs          |   1 +
>>  net/filter-mirror.c        | 181 +++++++++++++++++++++++++++++++++++++++++++++
>>  qemu-options.hx            |   5 ++
>>  tests/.gitignore           |   1 +
>>  tests/Makefile             |   2 +
>>  tests/test-filter-mirror.c |  90 ++++++++++++++++++++++
>>  vl.c                       |   3 +-
>>  7 files changed, 282 insertions(+), 1 deletion(-)
>>  create mode 100644 net/filter-mirror.c
>>  create mode 100644 tests/test-filter-mirror.c
>>
> Applied to -net with minor tweaks on commit log.
>
> Thanks
>

Actually reverted, since I get:

tests/test-filter-mirror.o: In function `test_mirror':
/home/devel/git/qemu/tests/test-filter-mirror.c:36: warning: the use of
`mktemp' is dangerous, better use `mkstemp' or `mkdtemp'

Please fix this and send a V7.

Thanks