Re: [Qemu-devel] [PATCH V6 0/2] net/filter-mirror:add filter-mirror and unit test

[Zhang Chen <zhangchen.fnst@cn.fujitsu.com>]

On 02/26/2016 03:06 PM, Jason Wang wrote:
>
> On 02/24/2016 04:08 PM, Jason Wang wrote:
>> On 02/24/2016 02:54 PM, Zhang Chen wrote:
>>> Filter-mirror is a netfilter plugin.
>>> It gives qemu the ability to mirror
>>> packets to a chardev.
>>>
>>> v6:
>>>   - Address Jason's comments.
>>>
>>> v5:
>>>   - Address Jason's comments.
>>>
>>> v4:
>>>   - Address Jason's comments.
>>>
>>> v3:
>>>   - Add filter-mirror unit test according
>>>     to Jason's comments
>>>   - Address zhanghailiang's comments.
>>>   - Address Jason's comments.
>>>
>>> v2:
>>>   - Address zhanghailiang's comments.
>>>   - Address Eric Blake's comments.
>>>   - Address Yang Hongyang's comments.
>>>   - Address Dave's comments.
>>>
>>> v1:
>>>   initial patch.
>>>
>>>
>>> Zhang Chen (2):
>>>    net/filter-mirror:Add filter-mirror
>>>    tests/test-filter-mirror:add filter-mirror unit test
>>>
>>>   net/Makefile.objs          |   1 +
>>>   net/filter-mirror.c        | 181 +++++++++++++++++++++++++++++++++++++++++++++
>>>   qemu-options.hx            |   5 ++
>>>   tests/.gitignore           |   1 +
>>>   tests/Makefile             |   2 +
>>>   tests/test-filter-mirror.c |  90 ++++++++++++++++++++++
>>>   vl.c                       |   3 +-
>>>   7 files changed, 282 insertions(+), 1 deletion(-)
>>>   create mode 100644 net/filter-mirror.c
>>>   create mode 100644 tests/test-filter-mirror.c
>>>
>> Applied to -net with minor tweaks on commit log.
>>
>> Thanks
>>
> Actually reverted, since I get:
>
> tests/test-filter-mirror.o: In function `test_mirror':
> /home/devel/git/qemu/tests/test-filter-mirror.c:36: warning: the use of
> `mktemp' is dangerous, better use `mkstemp' or `mkdtemp'
>
> Please fix this and send a V7.
>
> Thanks
>
>

OK, I will fix it in V7
Thanks
zhangchen

>
> .
>

-- 
Thanks
zhangchen