[Qemu-devel] [PATCH] doc/memory.txt: correct a logic error

[Qemu-devel] [PATCH] doc/memory.txt: correct a logic error

[xiaoqiang zhao]

In the regions overlap example, region B has a higher priority thus
should has a larger priority number than C.

Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
---
 docs/memory.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/memory.txt b/docs/memory.txt
index 8745f76..d0aca05 100644
--- a/docs/memory.txt
+++ b/docs/memory.txt
@@ -180,8 +180,8 @@ aliases that leave holes then the lower priority region will appear in these
 holes too.)
 
 For example, suppose we have a container A of size 0x8000 with two subregions
-B and C. B is a container mapped at 0x2000, size 0x4000, priority 1; C is
-an MMIO region mapped at 0x0, size 0x6000, priority 2. B currently has two
+B and C. B is a container mapped at 0x2000, size 0x4000, priority 2; C is
+an MMIO region mapped at 0x0, size 0x6000, priority 1. B currently has two
 of its own subregions: D of size 0x1000 at offset 0 and E of size 0x1000 at
 offset 0x2000. As a diagram:
 
-- 
2.1.4

Re: [Qemu-devel] [PATCH] doc/memory.txt: correct a logic error

[Peter Maydell]

On 26 February 2016 at 08:40, xiaoqiang zhao <zxq_yx_007@163.com> wrote:
> In the regions overlap example, region B has a higher priority thus
> should has a larger priority number than C.
>
> Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
> ---
>  docs/memory.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/memory.txt b/docs/memory.txt
> index 8745f76..d0aca05 100644
> --- a/docs/memory.txt
> +++ b/docs/memory.txt
> @@ -180,8 +180,8 @@ aliases that leave holes then the lower priority region will appear in these
>  holes too.)
>
>  For example, suppose we have a container A of size 0x8000 with two subregions
> -B and C. B is a container mapped at 0x2000, size 0x4000, priority 1; C is
> -an MMIO region mapped at 0x0, size 0x6000, priority 2. B currently has two
> +B and C. B is a container mapped at 0x2000, size 0x4000, priority 2; C is
> +an MMIO region mapped at 0x0, size 0x6000, priority 1. B currently has two
>  of its own subregions: D of size 0x1000 at offset 0 and E of size 0x1000 at
>  offset 0x2000. As a diagram:

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

I suspect I was thinking of other systems where lower numbers are higher
priorities...

thanks
-- PMM

Re: [Qemu-devel] [PATCH] doc/memory.txt: correct a logic error

[hitmoon]

在 2016年02月26日 18:25, Peter Maydell 写道:
> On 26 February 2016 at 08:40, xiaoqiang zhao <zxq_yx_007@163.com> wrote:
>> In the regions overlap example, region B has a higher priority thus
>> should has a larger priority number than C.
>>
>> Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
>> ---
>>   docs/memory.txt | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/docs/memory.txt b/docs/memory.txt
>> index 8745f76..d0aca05 100644
>> --- a/docs/memory.txt
>> +++ b/docs/memory.txt
>> @@ -180,8 +180,8 @@ aliases that leave holes then the lower priority region will appear in these
>>   holes too.)
>>
>>   For example, suppose we have a container A of size 0x8000 with two subregions
>> -B and C. B is a container mapped at 0x2000, size 0x4000, priority 1; C is
>> -an MMIO region mapped at 0x0, size 0x6000, priority 2. B currently has two
>> +B and C. B is a container mapped at 0x2000, size 0x4000, priority 2; C is
>> +an MMIO region mapped at 0x0, size 0x6000, priority 1. B currently has two
>>   of its own subregions: D of size 0x1000 at offset 0 and E of size 0x1000 at
>>   offset 0x2000. As a diagram:
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> I suspect I was thinking of other systems where lower numbers are higher
> priorities...
>
> thanks
> -- PMM
Well, it's not consistency.

Re: [Qemu-devel] [PATCH] doc/memory.txt: correct a logic error

[Paolo Bonzini]

On 26/02/2016 09:40, xiaoqiang zhao wrote:
> In the regions overlap example, region B has a higher priority thus
> should has a larger priority number than C.
> 
> Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
> ---
>  docs/memory.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/memory.txt b/docs/memory.txt
> index 8745f76..d0aca05 100644
> --- a/docs/memory.txt
> +++ b/docs/memory.txt
> @@ -180,8 +180,8 @@ aliases that leave holes then the lower priority region will appear in these
>  holes too.)
>  
>  For example, suppose we have a container A of size 0x8000 with two subregions
> -B and C. B is a container mapped at 0x2000, size 0x4000, priority 1; C is
> -an MMIO region mapped at 0x0, size 0x6000, priority 2. B currently has two
> +B and C. B is a container mapped at 0x2000, size 0x4000, priority 2; C is
> +an MMIO region mapped at 0x0, size 0x6000, priority 1. B currently has two
>  of its own subregions: D of size 0x1000 at offset 0 and E of size 0x1000 at
>  offset 0x2000. As a diagram:
>  
> 

Queued for the next pull request, thanks.

Paolo