From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZFne-0004Jj-L0 for qemu-devel@nongnu.org; Fri, 26 Feb 2016 05:39:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZFnZ-0006rU-Pn for qemu-devel@nongnu.org; Fri, 26 Feb 2016 05:39:06 -0500 Received: from m12-15.163.com ([220.181.12.15]:59974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZFnY-0006pZ-QS for qemu-devel@nongnu.org; Fri, 26 Feb 2016 05:39:01 -0500 References: <1456476051-15121-1-git-send-email-zxq_yx_007@163.com> From: hitmoon Message-ID: <56D02AA0.70301@163.com> Date: Fri, 26 Feb 2016 18:36:16 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] doc/memory.txt: correct a logic error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , QEMU Developers 在 2016年02月26日 18:25, Peter Maydell 写道: > On 26 February 2016 at 08:40, xiaoqiang zhao wrote: >> In the regions overlap example, region B has a higher priority thus >> should has a larger priority number than C. >> >> Signed-off-by: xiaoqiang zhao >> --- >> docs/memory.txt | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/docs/memory.txt b/docs/memory.txt >> index 8745f76..d0aca05 100644 >> --- a/docs/memory.txt >> +++ b/docs/memory.txt >> @@ -180,8 +180,8 @@ aliases that leave holes then the lower priority region will appear in these >> holes too.) >> >> For example, suppose we have a container A of size 0x8000 with two subregions >> -B and C. B is a container mapped at 0x2000, size 0x4000, priority 1; C is >> -an MMIO region mapped at 0x0, size 0x6000, priority 2. B currently has two >> +B and C. B is a container mapped at 0x2000, size 0x4000, priority 2; C is >> +an MMIO region mapped at 0x0, size 0x6000, priority 1. B currently has two >> of its own subregions: D of size 0x1000 at offset 0 and E of size 0x1000 at >> offset 0x2000. As a diagram: > Reviewed-by: Peter Maydell > > I suspect I was thinking of other systems where lower numbers are higher > priorities... > > thanks > -- PMM Well, it's not consistency.