From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZIBc-00072N-FV for qemu-devel@nongnu.org; Fri, 26 Feb 2016 08:12:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZIBb-0003Ka-Ff for qemu-devel@nongnu.org; Fri, 26 Feb 2016 08:12:00 -0500 References: <1456247799-9593-1-git-send-email-kwolf@redhat.com> <1456247799-9593-3-git-send-email-kwolf@redhat.com> <56CDEE65.3060906@redhat.com> <20160225125103.GF5757@andariel.pipo.sk> From: Max Reitz Message-ID: <56D04F13.9040609@redhat.com> Date: Fri, 26 Feb 2016 14:11:47 +0100 MIME-Version: 1.0 In-Reply-To: <20160225125103.GF5757@andariel.pipo.sk> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ss7pBHxoFPx4vqiEJ9HOLgQIlKiQgQWGR" Subject: Re: [Qemu-devel] [PATCH 2/2] hmp: Extend drive_del to delete nodes without BB List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Krempa Cc: Kevin Wolf , armbru@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ss7pBHxoFPx4vqiEJ9HOLgQIlKiQgQWGR Content-Type: multipart/mixed; boundary="KEUPh9BkxSTDemK2Og9vC6nS6qwBUx43e" From: Max Reitz To: Peter Krempa Cc: Kevin Wolf , qemu-block@nongnu.org, armbru@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org Message-ID: <56D04F13.9040609@redhat.com> Subject: Re: [PATCH 2/2] hmp: Extend drive_del to delete nodes without BB References: <1456247799-9593-1-git-send-email-kwolf@redhat.com> <1456247799-9593-3-git-send-email-kwolf@redhat.com> <56CDEE65.3060906@redhat.com> <20160225125103.GF5757@andariel.pipo.sk> In-Reply-To: <20160225125103.GF5757@andariel.pipo.sk> --KEUPh9BkxSTDemK2Og9vC6nS6qwBUx43e Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 25.02.2016 13:51, Peter Krempa wrote: > On Wed, Feb 24, 2016 at 18:54:45 +0100, Max Reitz wrote: >> On 23.02.2016 18:16, Kevin Wolf wrote: >>> Now that we can use drive_add to create new nodes without a BB, we al= so >>> want to be able to delete such nodes again. >>> >>> Signed-off-by: Kevin Wolf >>> --- >>> blockdev.c | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >=20 > [..] >=20 >>> >> >> It's a bit strange to require the user to specify the node name using >> "node-name" for drive_add, but the to use "id" in drive_del; especiall= y >> because x-blockdev-del uses "node-name", too. >=20 > Well, since 'x-blockdev-del' is considered unstable yet I can't really > use it in libvirt, thus we discussed using drive_del as a workaround. >=20 > It makes partially sense since we'd add the new node with 'drive_add' i= n > the first place. Yes, you're right. However, my question was solely about the parameter name (reusing "id" for a node name). As Kevin replied, for HMP the parameter name doesn't really matter to the user anyway, so reusing the "id" parameter here is completely fine. Max --KEUPh9BkxSTDemK2Og9vC6nS6qwBUx43e-- --ss7pBHxoFPx4vqiEJ9HOLgQIlKiQgQWGR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW0E8TAAoJEDuxQgLoOKytmKcH/3pM1Kl3m2VjzYvuL0zbf0ZQ KWL9niIgvgfQI7LE7X1DqQEHnIZmuEEimFsFEAdRpRYmYdNjMazYQsduoJAadznb k7IbqU4AxHLOGXuGQSqNFiohSK/ErYIs1n9k6JRrOawxp2NtD8jNgWCuH7jcDUuo GOBUMbkVvgQebQb0FLry5zM+7egvayEcQGdeLSZyHWBh2GAfJTauOTyxtrJpWsPn raled00WtRafmqqokcf+oFVPQ1qUr/KSbfJM5YN9GFJ/ou49yLyXOUR5oruh8Zmd JYkhlv6t3ysC4dDMrds4QNt07CltUBzdEc2S52QVSI3JdHnVXrDU0dzVuRQm1gU= =SyW0 -----END PGP SIGNATURE----- --ss7pBHxoFPx4vqiEJ9HOLgQIlKiQgQWGR--