From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39577)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1aZKKE-00050B-4b
	for qemu-devel@nongnu.org; Fri, 26 Feb 2016 10:29:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1aZKKB-00086D-FZ
	for qemu-devel@nongnu.org; Fri, 26 Feb 2016 10:29:02 -0500
Received: from mx2.parallels.com ([199.115.105.18]:54855)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1aZKKB-00084g-AD
	for qemu-devel@nongnu.org; Fri, 26 Feb 2016 10:28:59 -0500
References: <cover.1456480352.git.amit.shah@redhat.com>
	<CAFEAcA9V8ELQQqzVjA6hKsXsmjkGW3vHh+_k3gqH84ADXENxNQ@mail.gmail.com>
	<20160226131554.GP10967@grmbl.mre> <56D0681A.5000705@openvz.org>
	<20160226151452.GQ10967@grmbl.mre>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <56D06F27.3090105@openvz.org>
Date: Fri, 26 Feb 2016 18:28:39 +0300
MIME-Version: 1.0
In-Reply-To: <20160226151452.GQ10967@grmbl.mre>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 0/6] migration pull
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Juan Quintela <quintela@redhat.com>, qemu list <qemu-devel@nongnu.org>, Matthew Fortune <Matthew.Fortune@imgtec.com>, richard.weiyang@gmail.com, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Sascha Silbe <silbe@linux.vnet.ibm.com>

On 02/26/2016 06:14 PM, Amit Shah wrote:
> On (Fri) 26 Feb 2016 [17:58:34], Denis V. Lunev wrote:
>> On 02/26/2016 04:15 PM, Amit Shah wrote:
>>> On (Fri) 26 Feb 2016 [12:23:01], Peter Maydell wrote:
>>>> Hi. I'm afraid this causes make check to fail:
>>> Oops, I should've caught that.
>>>
>>>>    /i386/ahci/flush/migrate:
>>>>    /i386/ahci/migrate/sanity:
>>>>    /i386/ahci/migrate/dma/simple:
>>>>    /i386/ahci/migrate/dma/halted:
>>>>    /i386/ahci/migrate/ncq/simple:
>>>>    /i386/ahci/migrate/ncq/halted:
>>>> Broken pipe
>>>> FAIL
>>>> GTester: last random seed: R02S34da744548f394684dbb7b6d11e14043
>>>> (pid=56820)
>>>>
>>>> (failure seen on ppc64be, x86-64 linux, aarch64, but not aarch32 or OSX).
>>> AHCI tests are failing due to Denis's patches.  I'm checking why.
>>>
>>> 		Amit
>> oops. Interesting :(
> Right - use-after-free; this on top of your patch fixes it.
>
>
> diff --git a/migration/migration.c b/migration/migration.c
> index f82fdf6..0129d9f 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -366,9 +366,8 @@ static void process_incoming_migration_bh(void *opaque)
>        */
>       migrate_set_state(&mis->state, MIGRATION_STATUS_ACTIVE,
>                         MIGRATION_STATUS_COMPLETED);
> -    migration_incoming_state_destroy();
> -
>       qemu_bh_delete(mis->bh);
> +    migration_incoming_state_destroy();
>   }
>   
>   static void process_incoming_migration_co(void *opaque)
>
>
> 		Amit
sorry :( last minute changes are bad...