[Qemu-devel] [PATCH v3 0/2] doc/memory: cleanup

[Qemu-devel] [PATCH v3 0/2] doc/memory: cleanup

[Cao jin]

see each commit message

Cao jin (2):
  doc/memory: fix typo
  doc/memory: remove the stray extra '-'

 docs/memory.txt | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

-- 
2.1.0

[Qemu-devel] [PATCH v3 1/2] doc/memory: fix typo

[Cao jin]

Fix typo while also modify its description, make the text parallel to
the existing .impl.unaligned doc.

Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
 docs/memory.txt | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/docs/memory.txt b/docs/memory.txt
index 8745f76..306280e 100644
--- a/docs/memory.txt
+++ b/docs/memory.txt
@@ -297,8 +297,9 @@ various constraints can be supplied to control how these callbacks are called:
  - .valid.min_access_size, .valid.max_access_size define the access sizes
    (in bytes) which the device accepts; accesses outside this range will
    have device and bus specific behaviour (ignored, or machine check)
- - .valid.aligned specifies that the device only accepts naturally aligned
-   accesses.  Unaligned accesses invoke device and bus specific behaviour.
+ - .valid.unaligned specifies that the *device being modelled* supports
+   unaligned accesses. if false, unaligned accesses will invoke the appropriate
+   bus or CPU specific behaviour.
  - .impl.min_access_size, .impl.max_access_size define the access sizes
    (in bytes) supported by the *implementation*; other access sizes will be
    emulated using the ones available.  For example a 4-byte write will be
-- 
2.1.0

Re: [Qemu-devel] [PATCH v3 1/2] doc/memory: fix typo

[Peter Maydell]

On 26 February 2016 at 11:29, Cao jin <caoj.fnst@cn.fujitsu.com> wrote:
> Fix typo while also modify its description, make the text parallel to
> the existing .impl.unaligned doc.

This still isn't a typo...

> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
>  docs/memory.txt | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/docs/memory.txt b/docs/memory.txt
> index 8745f76..306280e 100644
> --- a/docs/memory.txt
> +++ b/docs/memory.txt
> @@ -297,8 +297,9 @@ various constraints can be supplied to control how these callbacks are called:
>   - .valid.min_access_size, .valid.max_access_size define the access sizes
>     (in bytes) which the device accepts; accesses outside this range will
>     have device and bus specific behaviour (ignored, or machine check)
> - - .valid.aligned specifies that the device only accepts naturally aligned
> -   accesses.  Unaligned accesses invoke device and bus specific behaviour.
> + - .valid.unaligned specifies that the *device being modelled* supports
> +   unaligned accesses. if false, unaligned accesses will invoke the appropriate
> +   bus or CPU specific behaviour.

Needs to be a semicolon before the "if".

Either "something something. If foo" or "something something; if foo"
are correct as punctuation. Since we're aiming to follow the same
construction as the existing text for .impl.unaligned, we want the
semicolon and lowercase.

>   - .impl.min_access_size, .impl.max_access_size define the access sizes
>     (in bytes) supported by the *implementation*; other access sizes will be
>     emulated using the ones available.  For example a 4-byte write will be
> --
> 2.1.0

thanks
-- PMM

Re: [Qemu-devel] [PATCH v3 1/2] doc/memory: fix typo

[Cao jin]

On 02/26/2016 07:36 PM, Peter Maydell wrote:
> On 26 February 2016 at 11:29, Cao jin <caoj.fnst@cn.fujitsu.com> wrote:

>
> Needs to be a semicolon before the "if".
>
> Either "something something. If foo" or "something something; if foo"
> are correct as punctuation. Since we're aiming to follow the same
> construction as the existing text for .impl.unaligned, we want the
> semicolon and lowercase.
>

interesting punctuation knowledge to me(as a non-native speaker). Thanks 
for the comment:)

-- 
Yours Sincerely,

Cao jin

[Qemu-devel] [PATCH v3 2/2] doc/memory: remove the stray extra '-'

[Cao jin]

Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
 docs/memory.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/memory.txt b/docs/memory.txt
index 306280e..d5c216c 100644
--- a/docs/memory.txt
+++ b/docs/memory.txt
@@ -185,8 +185,8 @@ an MMIO region mapped at 0x0, size 0x6000, priority 2. B currently has two
 of its own subregions: D of size 0x1000 at offset 0 and E of size 0x1000 at
 offset 0x2000. As a diagram:
 
-        0      1000   2000   3000   4000   5000   6000   7000    8000
-        |------|------|------|------|------|------|------|-------|
+        0      1000   2000   3000   4000   5000   6000   7000   8000
+        |------|------|------|------|------|------|------|------|
   A:    [                                                       ]
   C:    [CCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC]
   B:                  [                          ]
-- 
2.1.0

Re: [Qemu-devel] [PATCH v3 2/2] doc/memory: remove the stray extra '-'

[Peter Maydell]

On 26 February 2016 at 11:29, Cao jin <caoj.fnst@cn.fujitsu.com> wrote:
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
>  docs/memory.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/memory.txt b/docs/memory.txt
> index 306280e..d5c216c 100644
> --- a/docs/memory.txt
> +++ b/docs/memory.txt
> @@ -185,8 +185,8 @@ an MMIO region mapped at 0x0, size 0x6000, priority 2. B currently has two
>  of its own subregions: D of size 0x1000 at offset 0 and E of size 0x1000 at
>  offset 0x2000. As a diagram:
>
> -        0      1000   2000   3000   4000   5000   6000   7000    8000
> -        |------|------|------|------|------|------|------|-------|
> +        0      1000   2000   3000   4000   5000   6000   7000   8000
> +        |------|------|------|------|------|------|------|------|
>    A:    [                                                       ]
>    C:    [CCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC]
>    B:                  [                          ]
> --

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM