From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aa0G7-0004gU-G4 for qemu-devel@nongnu.org; Sun, 28 Feb 2016 07:15:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aa0G3-0006e3-Rk for qemu-devel@nongnu.org; Sun, 28 Feb 2016 07:15:35 -0500 Received: from mout.web.de ([212.227.17.11]:49501) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aa0G3-0006dg-Hi for qemu-devel@nongnu.org; Sun, 28 Feb 2016 07:15:31 -0500 References: <1456660346-29148-1-git-send-email-rita.sinha89@gmail.com> From: Jan Kiszka Message-ID: <56D2E4D9.60209@web.de> Date: Sun, 28 Feb 2016 13:15:21 +0100 MIME-Version: 1.0 In-Reply-To: <1456660346-29148-1-git-send-email-rita.sinha89@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qBLKj4g1sv0SvodgWxoKgTPNA4Nr1a5pa" Subject: Re: [Qemu-devel] [PATCH] kvm: x86: q35: Add support for -machine kernel_irqchip=split for q35 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Rita Sinha , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, gingell@google.com, stefanha@gmail.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qBLKj4g1sv0SvodgWxoKgTPNA4Nr1a5pa Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 2016-02-28 12:52, Rita Sinha wrote: > The split IRQ chip mode via KVM_CAP_SPLIT_IRQCHIP was introduced with c= ommit > 15eafc2e602ff8c37c6e132eb8c63fec8fc17175 but was broken for q35. This p= atch You may abbreviate hashes in logs. I usually use 10 digits, some even only 8. There is a risk of collisions, but the context will resolve it again for the reader. > makes kernel_irqchip=3Dsplit functional for q35. Signed-off is missing. > --- > hw/i386/pc_q35.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > index 46522c9..ff6a5af 100644 > --- a/hw/i386/pc_q35.c > +++ b/hw/i386/pc_q35.c > @@ -39,6 +39,7 @@ > #include "hw/kvm/clock.h" > #include "hw/pci-host/q35.h" > #include "exec/address-spaces.h" > +#include "hw/i386/pc.h" > #include "hw/i386/ich9.h" > #include "hw/smbios/smbios.h" > #include "hw/ide/pci.h" > @@ -145,7 +146,7 @@ static void pc_q35_init(MachineState *machine) > =20 > /* irq lines */ > gsi_state =3D g_malloc0(sizeof(*gsi_state)); > - if (kvm_irqchip_in_kernel()) { > + if (kvm_ioapic_in_kernel()) { > kvm_pc_setup_irq_routing(pcmc->pci_enabled); > gsi =3D qemu_allocate_irqs(kvm_pc_gsi_handler, gsi_state, > GSI_NUM_PINS); > @@ -192,7 +193,7 @@ static void pc_q35_init(MachineState *machine) > /*end early*/ > isa_bus_irqs(isa_bus, gsi); > =20 > - if (kvm_irqchip_in_kernel()) { > + if (kvm_pit_in_kernel()) { kvm_pic_in_kernel > i8259 =3D kvm_i8259_init(isa_bus); > } else if (xen_enabled()) { > i8259 =3D xen_interrupt_controller_init(); >=20 Jan --qBLKj4g1sv0SvodgWxoKgTPNA4Nr1a5pa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlbS5NkACgkQitSsb3rl5xQhHQCcCkC1aGpqJECRKqGuguFdro/6 ubIAoIqI8a0IJ9ZTIJCNkeLu+WbckJ4K =e24i -----END PGP SIGNATURE----- --qBLKj4g1sv0SvodgWxoKgTPNA4Nr1a5pa--