From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaCrB-0002uz-Dp for qemu-devel@nongnu.org; Sun, 28 Feb 2016 20:42:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aaCr7-00036I-2X for qemu-devel@nongnu.org; Sun, 28 Feb 2016 20:42:41 -0500 Received: from mail-pa0-x244.google.com ([2607:f8b0:400e:c03::244]:34413) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaCr6-00035y-RU for qemu-devel@nongnu.org; Sun, 28 Feb 2016 20:42:36 -0500 Received: by mail-pa0-x244.google.com with SMTP id yy13so7768594pab.1 for ; Sun, 28 Feb 2016 17:42:35 -0800 (PST) References: <1456486323-8047-1-git-send-email-david@gibson.dropbear.id.au> <1456486323-8047-11-git-send-email-david@gibson.dropbear.id.au> From: Alexey Kardashevskiy Message-ID: <56D3A204.2080806@ozlabs.ru> Date: Mon, 29 Feb 2016 12:42:28 +1100 MIME-Version: 1.0 In-Reply-To: <1456486323-8047-11-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/12] spapr_pci: (Mostly) remove spapr-pci-vfio-host-bridge List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , benh@kernel.crashing.org Cc: agraf@suse.de, qemu-devel@nongnu.org, gwshan@au1.ibm.com, mdroth@linux.vnet.ibm.com, alex.williamson@redhat.com, qemu-ppc@nongnu.org On 02/26/2016 10:32 PM, David Gibson wrote: > Now that the regular spapr-pci-host-bridge can handle EEH, there are only > two things that spapr-pci-vfio-host-bridge does differently: > 1. automatically sizes its DMA window to match the host IOMMU > 2. checks if the attached VFIO container is backed by the > VFIO_SPAPR_TCE_IOMMU type on the host > > (1) is not particularly useful, since the default window used by the > regular host bridge will work with the host IOMMU configuration on all > current systems anyway. > > Plus, automatically changing guest visible configuration (such as the DMA > window) based on host settings is generally a bad idea. btw why exactly is it a bad idea? Anyway, Reviewed-by: Alexey Kardashevskiy -- Alexey