From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaIFY-0003kF-1L for qemu-devel@nongnu.org; Mon, 29 Feb 2016 02:28:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aaIFT-0003jg-VU for qemu-devel@nongnu.org; Mon, 29 Feb 2016 02:28:11 -0500 Received: from mail-pf0-x229.google.com ([2607:f8b0:400e:c00::229]:35948) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaIFT-0003jU-OF for qemu-devel@nongnu.org; Mon, 29 Feb 2016 02:28:07 -0500 Received: by mail-pf0-x229.google.com with SMTP id t66so21715698pfb.3 for ; Sun, 28 Feb 2016 23:28:07 -0800 (PST) References: <1456729587-17229-1-git-send-email-david@gibson.dropbear.id.au> <1456729587-17229-4-git-send-email-david@gibson.dropbear.id.au> From: Alexey Kardashevskiy Message-ID: <56D3F302.2050308@ozlabs.ru> Date: Mon, 29 Feb 2016 18:28:02 +1100 MIME-Version: 1.0 In-Reply-To: <1456729587-17229-4-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv2 3/7] spapr_pci: Eliminate class callbacks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , alex.williamson@redhat.com Cc: qemu-ppc@nongnu.org, agraf@suse.de, gwshan@au1.ibm.com, qemu-devel@nongnu.org On 02/29/2016 06:06 PM, David Gibson wrote: > The EEH operations in the spapr-vfio-pci-host-bridge no longer rely on the > special groupid field in sPAPRPHBVFIOState. So we can simplify, removing > the class specific callbacks with direct calls based on a simple > spapr_phb_eeh_enabled() helper. For now we implement that in terms of > a boolean in the class, but we'll continue to clean that up later. > > On its own this is a rather strange way of doing things, but it's a useful > intermediate step to further cleanups. > > Signed-off-by: David Gibson Reviewed-by: Alexey Kardashevskiy -- Alexey