From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: David Gibson <david@gibson.dropbear.id.au>, alex.williamson@redhat.com
Cc: qemu-ppc@nongnu.org, agraf@suse.de, gwshan@au1.ibm.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv2 4/7] spapr_pci: Allow EEH on spapr-pci-host-bridge
Date: Mon, 29 Feb 2016 18:28:12 +1100 [thread overview]
Message-ID: <56D3F30C.5020000@ozlabs.ru> (raw)
In-Reply-To: <1456729587-17229-5-git-send-email-david@gibson.dropbear.id.au>
On 02/29/2016 06:06 PM, David Gibson wrote:
> Now that the EEH code is independent of the special
> spapr-vfio-pci-host-bridge device, we can allow it on all spapr PCI
> host bridges instead. We do this by changing spapr_phb_eeh_available()
> to be based on the vfio_eeh_as_ok() call instead of the host bridge class.
>
> Because the value of vfio_eeh_as_ok() can change with devices being
> hotplugged or unplugged, this can potentially lead to some strange edge
> cases where the guest starts using EEH, then it starts failing because
> of a change in status.
>
> However, it's not really any worse than the current situation. Cases that
> would have worked previously will still work (i.e. VFIO devices from at
> most one VFIO IOMMU group per vPHB), it's just that it's no longer
> necessary to use spapr-vfio-pci-host-bridge with the groupid pre-specified.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
--
Alexey
next prev parent reply other threads:[~2016-02-29 7:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 7:06 [Qemu-devel] [PATCHv2 0/7] Allow EEH on spapr-pci-host-bridge devices David Gibson
2016-02-29 7:06 ` [Qemu-devel] [PATCHv2 1/7] vfio: Start improving VFIO/EEH interface David Gibson
2016-02-29 7:27 ` Alexey Kardashevskiy
2016-03-07 19:49 ` Alex Williamson
2016-03-08 1:34 ` David Gibson
2016-02-29 7:06 ` [Qemu-devel] [PATCHv2 2/7] spapr_pci: Switch to vfio_eeh_as_op() interface David Gibson
2016-02-29 7:06 ` [Qemu-devel] [PATCHv2 3/7] spapr_pci: Eliminate class callbacks David Gibson
2016-02-29 7:28 ` Alexey Kardashevskiy
2016-02-29 7:06 ` [Qemu-devel] [PATCHv2 4/7] spapr_pci: Allow EEH on spapr-pci-host-bridge David Gibson
2016-02-29 7:28 ` Alexey Kardashevskiy [this message]
2016-02-29 7:06 ` [Qemu-devel] [PATCHv2 5/7] spapr_pci: (Mostly) remove spapr-pci-vfio-host-bridge David Gibson
2016-02-29 7:28 ` Alexey Kardashevskiy
2016-02-29 7:06 ` [Qemu-devel] [PATCHv2 6/7] spapr_pci: Remove finish_realize hook David Gibson
2016-02-29 7:06 ` [Qemu-devel] [PATCHv2 7/7] vfio: Eliminate vfio_container_ioctl() David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D3F30C.5020000@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=agraf@suse.de \
--cc=alex.williamson@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=gwshan@au1.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).