From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49860) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaLpy-0006Sy-Vz for qemu-devel@nongnu.org; Mon, 29 Feb 2016 06:18:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aaLpt-0003rG-Vm for qemu-devel@nongnu.org; Mon, 29 Feb 2016 06:18:02 -0500 Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]:36362) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaLpt-0003qK-Lo for qemu-devel@nongnu.org; Mon, 29 Feb 2016 06:17:57 -0500 Received: by mail-wm0-x236.google.com with SMTP id n186so43993733wmn.1 for ; Mon, 29 Feb 2016 03:17:57 -0800 (PST) Sender: Paolo Bonzini References: <1456320461-26756-1-git-send-email-pbonzini@redhat.com> <1456320461-26756-15-git-send-email-pbonzini@redhat.com> <20160229085711.GA26830@dnr.brq.redhat.com> <56D40A63.2060302@redhat.com> <20160229100406.GA3325@dnr.brq.redhat.com> <56D41AB5.2030803@redhat.com> <20160229110516.GB3325@dnr.brq.redhat.com> From: Paolo Bonzini Message-ID: <56D428E1.40509@redhat.com> Date: Mon, 29 Feb 2016 12:17:53 +0100 MIME-Version: 1.0 In-Reply-To: <20160229110516.GB3325@dnr.brq.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PULL 14/19] log: Redirect stderr to logfile if deamonized List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?J=c3=a1n_Tomko?= Cc: qemu-devel@nongnu.org, Dimitris Aragiorgis On 29/02/2016 12:05, Ján Tomko wrote: >> > > This works for me, but produces a warning: > CC util/log.o > util/log.c: In function ‘do_qemu_set_log’: > util/log.c:60:40: error: pointer/integer type mismatch in conditional expression [-Werror] > (is_daemonized() ? logfilename : qemu_loglevel)) { Thanks, that happens when you you interpret "test the patch" as "write down the truth table" and see if it makes sense. I'll fix the warning and send out the patch. Paolo