From: Paolo Bonzini <pbonzini@redhat.com>
To: alvise rigo <a.rigo@virtualopensystems.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: "MTTCG Devel" <mttcg@listserver.greensocs.com>,
"Mark Burton" <mark.burton@greensocs.com>,
"Claudio Fontana" <claudio.fontana@huawei.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Jani Kokkonen" <jani.kokkonen@huawei.com>,
"tech@virtualopensystems.com" <tech@virtualopensystems.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"KONRAD Frédéric" <fred.konrad@greensocs.com>
Subject: Re: [Qemu-devel] [mttcg] cputlb: Use async tlb_flush_by_mmuidx
Date: Mon, 29 Feb 2016 15:06:33 +0100 [thread overview]
Message-ID: <56D45069.8090206@redhat.com> (raw)
In-Reply-To: <CAH47eN1Vqy3KLnk9zBTUqAHbA1mnOMc3X1LMqjWXvgaByinB1Q@mail.gmail.com>
On 29/02/2016 15:02, alvise rigo wrote:
> > Yeah, that's the other approach -- really split the things that can
> > be async and do real "wait for completion" at points which must
> > synchronize. (Needs a little care since DMB is not the only such point.)
> > An initial implementation that does an immediate wait-for-completion
> > is probably simpler to review though, and add the real asynchrony
> > later. And either way you need an API for the target to wait for
> > completion.
> OK, so basically being sure that the target CPU performs the flush
> before executing the next TB is not enough. We need a sort of feedback
> that the flush has been done before emulating the next guest
> instruction. Did I get it right?
That risks getting deadlocks if CPU A asks B to flush the TLB and vice
versa. Using a halted state means that the VCPU thread goes through the
cpus.c loop and can for example service other CPUs' TLB flush requests.
Paolo
next prev parent reply other threads:[~2016-02-29 14:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 13:16 [Qemu-devel] [mttcg] cputlb: Use async tlb_flush_by_mmuidx Alvise Rigo
2016-02-29 13:21 ` Peter Maydell
2016-02-29 13:50 ` Paolo Bonzini
2016-02-29 13:55 ` Peter Maydell
2016-02-29 14:02 ` alvise rigo
2016-02-29 14:06 ` Paolo Bonzini [this message]
2016-02-29 14:18 ` alvise rigo
2016-03-04 14:28 ` alvise rigo
2016-03-07 20:18 ` Alex Bennée
2016-03-07 21:18 ` Paolo Bonzini
2016-03-11 11:08 ` alvise rigo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D45069.8090206@redhat.com \
--to=pbonzini@redhat.com \
--cc=a.rigo@virtualopensystems.com \
--cc=alex.bennee@linaro.org \
--cc=claudio.fontana@huawei.com \
--cc=fred.konrad@greensocs.com \
--cc=jani.kokkonen@huawei.com \
--cc=mark.burton@greensocs.com \
--cc=mttcg@listserver.greensocs.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=tech@virtualopensystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).