From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaXAi-0001BA-V6 for qemu-devel@nongnu.org; Mon, 29 Feb 2016 18:24:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aaXAh-000733-BE for qemu-devel@nongnu.org; Mon, 29 Feb 2016 18:24:12 -0500 References: <1456787973-19348-1-git-send-email-mreitz@redhat.com> From: Eric Blake Message-ID: <56D4D314.2070405@redhat.com> Date: Mon, 29 Feb 2016 16:24:04 -0700 MIME-Version: 1.0 In-Reply-To: <1456787973-19348-1-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OCTQeQkGWxAGXsSBONJkwxA3H7WfKua6S" Subject: Re: [Qemu-devel] [PATCH v2 00/16] qapi: Allow blockdev-add for NBD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , Markus Armbruster , qemu-devel@nongnu.org, Luiz Capitulino , Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OCTQeQkGWxAGXsSBONJkwxA3H7WfKua6S Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/29/2016 04:19 PM, Max Reitz wrote: > Turns out NBD is not so simple to do if you do it right. Anyway, this > series adds blockdev-add support for NBD clients. >=20 > Patches 1 and 2 add one less and one more complicated QDict function, > respectively, which I needed in later NBD patches: Patch 1 for handling= > legacy options (move "host" to "address.data.host" etc.) and patch 2 > because I'd like to use the input visitor for transforming the NBD > options into a SocketAddress. Unfortunately, the block layer uses > flattened QDicts everywhere, so we'll have to unflatten (erect?) them > before we can use that visitor. Dan had a patch proposal that called the operation "crumple"; I need to review both proposals and see which one I like. https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg04618.html >=20 > Patch 3 adds a test for qdict_unflatten(). >=20 > Patches 4, 5, 6, and 7 are minor patches with no functional relation to= > this series, other than later patches will touch the code they touch, > too. >=20 > Patches 8 and 9 prepare the code for the addition of a new option > prefix, which is "address.". >=20 > Patch 10 makes the NBD client accept a SocketAddress under the "address= " > option (or rather, a flattened SocketAddress QDict with its keys > prefixed by "address."). The old options "host", "port", and "path" are= > supported as legacy options and translated to the respective > SocketAddress representation. >=20 > Patch 11 drops usage of "host", "port", and "path" outside of > nbd_has_filename_options_conflict(), > nbd_process_legacy_socket_options(), and nbd_refresh_filename(), making= > those options nothing but legacy. >=20 > Patch 12, the goal of this series, is again not very complicated. >=20 > Patches 13, 14, and 15 are required for the iotest added in patch 16. I= t > will invoke qemu-nbd, so patch 13 is required. Besides qemu-nbd, it wil= l > launch an NBD server VM concurrently to the client VM, which is why > patch 14 is required. And finally, it will test whether we can add an > NBD BDS by passing it a file descriptor, which patch 15 is needed for > (so we use the socket_scm_helper to pass sockets to qemu). >=20 > Patch 16 then adds the iotest for NBD's blockdev-add interface. >=20 >=20 > Note on the relation to v1: As you can see, most of this series is > completely new. Patch 5 was patch 1 in v1, and the only thing that has > changed is that I removed the full stop at the end of the error message= ; > consequently I kept Eric's R-b. Looks like my review queue is getting longer because I (like several other people) are trying to post last-minute series before soft freeze. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OCTQeQkGWxAGXsSBONJkwxA3H7WfKua6S Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW1NMUAAoJEKeha0olJ0NqG0IIAKJZTYUCKfBl7vQGXs922vhi pqB1G4gZeSZTp6R+CgaiCJr636m/SiczbuPIe5tluib/jKRp5ob/R8SwdSaU4hJy xkgSuqPPfit4EnUQZhOf/vOcWz7UgYF1DtlgAn+eca/Sux+lNiYwlZnjg/1NcFvJ +FcaaKxkHF2ETSFtSLcJLYUpj09x3rET7ybo6uBRf4Uo09z82XbBMmMHB66s9d6A 9iubkv8C32b3jtLj8CNJQRQNgm/qJWhC74BqL4Pdln6VovegXDBzoyflPBiACVX/ 9ySiw3R9M+mwkGzZfhvNUjZV78+yv3stEIYZR82m9ivb6N2wDjPL6BY4Lu78kbY= =ZBLQ -----END PGP SIGNATURE----- --OCTQeQkGWxAGXsSBONJkwxA3H7WfKua6S--